From owner-cvs-sys Tue Nov 19 09:55:27 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id JAA20325 for cvs-sys-outgoing; Tue, 19 Nov 1996 09:55:27 -0800 (PST) Received: from rocky.mt.sri.com (rocky.mt.sri.com [206.127.76.100]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id JAA20281; Tue, 19 Nov 1996 09:54:53 -0800 (PST) Received: (from nate@localhost) by rocky.mt.sri.com (8.7.5/8.7.3) id KAA00374; Tue, 19 Nov 1996 10:54:44 -0700 (MST) Date: Tue, 19 Nov 1996 10:54:44 -0700 (MST) Message-Id: <199611191754.KAA00374@rocky.mt.sri.com> From: Nate Williams To: Bruce Evans Cc: cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-sys@freefall.freebsd.org, nate@freefall.freebsd.org Subject: Re: cvs commit: src/sys/i386/isa syscons.c In-Reply-To: <199611191747.EAA07534@godzilla.zeta.org.au> References: <199611191747.EAA07534@godzilla.zeta.org.au> Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Bruce Evans writes: > > Modified: sys/i386/isa syscons.c > > Log: > > Fix UserConfig w/syscons. > > ... > > Pre-initialize sc_port to IO_KBD which is really a kludge, but it's how > > the previous driver did it's job. > > > > Found by: remote GDB > > I have been running with this change for some time. If userconfig is > actually used, then the keyboard is unusable. Before this change, yes I agree. If sc_port isn't initialized it tries to read the data from port 0, which doesn't have any keyboard attached. :) The code is now almost exactly the same as the previous syscons 'getc' code, except for some busy waits and such. > Apparently a scancode > left over from quitting userconfig is interpreted as the keyboard > command byte. Huh? What context are we talking about here?