From owner-freebsd-testing@freebsd.org Thu Mar 28 23:07:52 2019 Return-Path: Delivered-To: freebsd-testing@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D649C154E07B for ; Thu, 28 Mar 2019 23:07:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 67570699EB for ; Thu, 28 Mar 2019 23:07:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 20FB2154E07A; Thu, 28 Mar 2019 23:07:51 +0000 (UTC) Delivered-To: testing@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D40BE154E078 for ; Thu, 28 Mar 2019 23:07:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6963D699E7 for ; Thu, 28 Mar 2019 23:07:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 89AD2795F for ; Thu, 28 Mar 2019 23:07:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x2SN7n9T006206 for ; Thu, 28 Mar 2019 23:07:49 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x2SN7n8o006205 for testing@freebsd.org; Thu, 28 Mar 2019 23:07:49 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: testing@freebsd.org Subject: [Bug 236857] Fix sysctl check for some sys/audit/process-control tests Date: Thu, 28 Mar 2019 23:07:49 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: tests X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: olivier@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: testing@freebsd.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.isobsolete attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Mar 2019 23:07:52 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D236857 Olivier Cochard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203223|0 |1 is obsolete| | --- Comment #7 from Olivier Cochard --- Created attachment 203226 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D203226&action= =3Dedit patch using ATF_REQUIRE_SYSCTL_INT Good remark. The original code was: ``` const char *capname =3D "kern.features.security_capability_mode"; ATF_REQUIRE_EQ(0, sysctlbyname(capname, &capinfo, &len, NULL, 0)) /* Without CAPABILITY_MODE enabled, cap_enter() returns ENOSYS */ if (!capinfo) atf_tc_skip("Capsicum is not enabled in the system"); ``` So, the purpose was to check if kern.features.security_capability_mode=3D= =3D1. Which mean "Check if capability is enabled". My patch was adding a "Check if this capability exist", before to check its status. If I remove the old sysctlbyname(3) call, I will not catch this condition: - Capability exist - But capability is disabled So I've read freebsd_test_suite/macros.h, and I've found these functions: - ATF_REQUIRE_FEATURE(_feature_name) - ATF_REQUIRE_KERNEL_MODULE(_mod_name) - ATF_REQUIRE_SYSCTL_INT(_mib_name, _required_value) And I think the best way should using ATF_REQUIRE_SYSCTL_INT(capname,1) that manage both condition. With this new patch: # kyua test sys/audit/process-control:cap_enter_success sys/audit/process-control:cap_enter_success -> skipped: sysctl for kern.features.security_capability_mode failed: No such file or director y [0.003s] Results file id is usr_tests.20190328-230635-632822 Results saved to /root/.kyua/store/results.usr_tests.20190328-230635-632822= .db 1/1 passed (0 failed) --=20 You are receiving this mail because: You are the assignee for the bug.=