Date: Sun, 14 Jan 2024 12:27:15 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 274813] www/elog: Revive port Message-ID: <bug-274813-7788-BPXrVzj9XP@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-274813-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-274813-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D274813 Robert Clausecker <fuz@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|New |Open --- Comment #5 from Robert Clausecker <fuz@FreeBSD.org> --- Thank you for the update. It seems to address my previous questions. I have since found some time to review your patch: - in a recent change, the MANPREFIX variable has been eliminated. Instead= use ${PREFIX}/share/man (preferred) or ${PREFIX}/man - as your port is currently set up, the daemon configured by the rc.d/elog file runs as root, not the elog user you added. Is this intentional? Try setting=20 elog_user and elog_group in the script to run the daemon with the given user.=20=20 It could also be that your daemon changes the user on its own, I didn't check. - all the files in WWWDIR are owned by elog. This means that if your daem= on runs as that user, all these files are writable by the daemon. This can= be a security problem: if an attacker manages to compromise the elog daemon= , he can persist himself by infecting these files. Unless files need to be written by the elog daemon, it is generally a good idea to give them to root:whe= el as usual. Only give files and directories to elog:elog if they need to be written by the daemon. It is usually best to lay out files such that pa= ths with daemon-writable files and those without are clearly separated. - check if you can place the configuration file in ${PREFIX}/etc as is convention. There can be exceptions, but it's usually better to have t= he configuration in the usual places. - your port installs a server key pair. This is usually wrong: each installation needs its own key pair, so the pair can't be shipped in the binary package. Many daemons can be configured to generate a key pa= ir on first start if none exists. Check if that would do the trick. Alternatively, add a post-install script or some magic to the rc.d scrip= t to generate the key pair after installation. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-274813-7788-BPXrVzj9XP>