From owner-svn-src-all@freebsd.org Mon May 27 16:40:56 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DE2CD15A5270; Mon, 27 May 2019 16:40:56 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8077E7451C; Mon, 27 May 2019 16:40:56 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 2B2DD1AEE1; Mon, 27 May 2019 16:40:56 +0000 (UTC) Date: Mon, 27 May 2019 16:40:56 +0000 From: Alexey Dokuchaev To: rgrimes@freebsd.org Cc: Konstantin Belousov , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r232071 - head/sys/vm Message-ID: <20190527164056.GA17917@FreeBSD.org> References: <20190527112155.GZ2748@kib.kiev.ua> <201905271421.x4RELOfH011064@gndrsh.dnsmgr.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201905271421.x4RELOfH011064@gndrsh.dnsmgr.net> User-Agent: Mutt/1.11.4 (2019-03-13) X-Rspamd-Queue-Id: 8077E7451C X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.95 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.95)[-0.954,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 May 2019 16:40:57 -0000 On Mon, May 27, 2019 at 07:21:24AM -0700, Rodney W. Grimes wrote: > I wish to assert again that all changes based on static > analysis tools require a formal code review by at minimum: > a) An expert in static analysis tools or a group of people > selected who we consider language experts. > b) An area expert from the area that is being affected > > We as a project look bad by not having this minimal > set of code reviews in place for things that are coming > from a source that is frought with introducing bad > change. Perhaps I should've just uploaded the log to let anyone interested have a look themselves. I've been only checking the kernel so far, but plan to cover userland as well later. freefall:/home/danfe/pvs-studio-2019-05-27.log.xz ./danfe