From owner-freebsd-standards@FreeBSD.ORG Sun Jul 3 00:24:00 2005 Return-Path: X-Original-To: freebsd-standards@FreeBSD.org Delivered-To: freebsd-standards@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B76CF16A42B; Sun, 3 Jul 2005 00:23:59 +0000 (GMT) (envelope-from ps@mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7FE3F441E8; Sun, 3 Jul 2005 00:15:53 +0000 (GMT) (envelope-from ps@mu.org) Received: by elvis.mu.org (Postfix, from userid 1000) id F139A60860; Sat, 2 Jul 2005 17:15:11 -0700 (PDT) X-Original-To: ps@mu.org Delivered-To: ps@mu.org Received: from mx2.freebsd.org (mx2.freebsd.org [216.136.204.119]) by elvis.mu.org (Postfix) with ESMTP id 6F4D15CA44 for ; Sat, 16 Apr 2005 09:37:45 -0700 (PDT) Received: from hub.freebsd.org (hub.freebsd.org [216.136.204.18]) by mx2.freebsd.org (Postfix) with ESMTP id 06AB1557CA; Sat, 16 Apr 2005 16:37:41 +0000 (GMT) (envelope-from owner-freebsd-bugs@freebsd.org) Received: from hub.freebsd.org (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id B2EF316A4CE; Sat, 16 Apr 2005 16:37:40 +0000 (GMT) Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F251C16A4CE; Sat, 16 Apr 2005 16:37:38 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id D9D3D43D45; Sat, 16 Apr 2005 16:37:38 +0000 (GMT) (envelope-from delphij@FreeBSD.org) Received: from freefall.freebsd.org (delphij@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j3GGbce8015888; Sat, 16 Apr 2005 16:37:38 GMT (envelope-from delphij@freefall.freebsd.org) Received: (from delphij@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j3GGbchA015884; Sat, 16 Apr 2005 16:37:38 GMT (envelope-from delphij) From: Xin LI Message-Id: <200504161637.j3GGbchA015884@freefall.freebsd.org> To: lx@knight.6test.edu.cn, delphij@FreeBSD.org, freebsd-bugs@FreeBSD.org, freebsd-standards@FreeBSD.org X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Sender: owner-freebsd-bugs@freebsd.org Errors-To: owner-freebsd-bugs@freebsd.org X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on elvis.mu.org X-Spam-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.0.2 X-Spam-Level: Cc: Subject: Re: kern/80008: Unnecessary requirement of sa_len in getnameinfo() X-BeenThere: freebsd-standards@freebsd.org List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Sun, 03 Jul 2005 00:24:00 -0000 X-Original-Date: Sat, 16 Apr 2005 16:37:38 GMT X-List-Received-Date: Sun, 03 Jul 2005 00:24:00 -0000 Synopsis: Unnecessary requirement of sa_len in getnameinfo() State-Changed-From-To: open->analyzed State-Changed-By: delphij State-Changed-When: Sat Apr 16 16:33:02 GMT 2005 State-Changed-Why: Dear freebsd-standards, Would you please review the following patch? I have consulted with POSIX standard and there is no requirement that there must be a "sa_len" field in sockaddr. Therefore, I think the check should be either removed, or be replaced with an assignment. Index: getnameinfo.c =================================================================== RCS file: /home/ncvs/src/lib/libc/net/getnameinfo.c,v retrieving revision 1.14 diff -u -r1.14 getnameinfo.c --- getnameinfo.c 1 May 2003 19:03:14 -0000 1.14 +++ getnameinfo.c 16 Apr 2005 16:31:33 -0000 @@ -109,9 +109,6 @@ if (sa == NULL) return EAI_FAIL; - if (sa->sa_len != salen) - return EAI_FAIL; - family = sa->sa_family; for (i = 0; afdl[i].a_af; i++) if (afdl[i].a_af == family) { Responsible-Changed-From-To: freebsd-bugs->freebsd-standards Responsible-Changed-By: delphij Responsible-Changed-When: Sat Apr 16 16:33:02 GMT 2005 Responsible-Changed-Why: Patch candidate for review. http://www.freebsd.org/cgi/query-pr.cgi?pr=80008 _______________________________________________ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscribe@freebsd.org"