From owner-cvs-all  Sat Oct 20  9:35:43 2001
Delivered-To: cvs-all@freebsd.org
Received: from b80216.upc-b.chello.nl (b80216.upc-b.chello.nl [212.83.80.216])
	by hub.freebsd.org (Postfix) with ESMTP
	id 7CD5837B405; Sat, 20 Oct 2001 09:35:39 -0700 (PDT)
Received: from adv.devet.org (adv.devet.org [192.168.1.2])
	by b80216.upc-b.chello.nl (Postfix) with ESMTP
	id 4927A68CF; Sat, 20 Oct 2001 18:35:38 +0200 (CEST)
Received: by adv.devet.org (Postfix, from userid 100)
	id C49AF3E13; Sat, 20 Oct 2001 18:35:37 +0200 (CEST)
Date: Sat, 20 Oct 2001 18:35:37 +0200
To: darrenr@FreeBSD.org
Cc: cvs-all@freebsd.org
Subject: Re: cvs commit: src/etc rc.network rc.shutdown src/etc/defaults rc.conf src/etc/mtree BSD.var.dist
Message-ID: <20011020183537.A33620@adv.devet.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200110200433.f9K4XCc52779@freefall.freebsd.org>
User-Agent: Mutt/1.3.22.1i
Organization: Eindhoven, the Netherlands
From: devet@devet.org (Arjan de Vet)
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

In article <200110200433.f9K4XCc52779@freefall.freebsd.org> you write:
>darrenr     2001/10/19 21:33:12 PDT
>
>  Modified files:
>    etc                  rc.network rc.shutdown 
>    etc/defaults         rc.conf 
>  Log:
>  Put in place for using ipfs use on shutdown and startup.

Hmm... with these default settings from defaults/rc.conf:

    ipfilter_program="/sbin/ipf -Fa -f"
    ipfs_flags=""
    ipfs_program="/sbin/ipfs"

these kind of expressions in /etc/rc.network:

    ${ipfilter_program:-/sbin/ipf -y}
    ${ipfs_program:-/sbin/ipfs -R} ${ipfs_flags}

will evaluate to:

    /sbin/ipf -Fa -f
    /sbin/ipfs

and that's not what is intended in these cases I think.

Furthermore I see these kind of expressions for ipfilter-related stuff
preceded by 'eval' a lot. That seems unnecessary to me.

Let me see if I can cleanup and test this stuff this weekend, the
ipfilter_program and ipnat_program variables for example are the only
*_program variables in defaults/rc.conf to have options included :-(.

Arjan

-- 
Arjan de Vet, Eindhoven, The Netherlands               <devet@devet.org>
URL: http://www.iae.nl/users/devet/             <Arjan.deVet@adv.iae.nl>

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message