From owner-svn-src-all@FreeBSD.ORG Thu Mar 11 23:39:57 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 108BF106566C; Thu, 11 Mar 2010 23:39:57 +0000 (UTC) (envelope-from tomelite82@gmail.com) Received: from mail-qy0-f175.google.com (mail-qy0-f175.google.com [209.85.221.175]) by mx1.freebsd.org (Postfix) with ESMTP id 5DCB58FC0C; Thu, 11 Mar 2010 23:39:56 +0000 (UTC) Received: by qyk5 with SMTP id 5so636691qyk.13 for ; Thu, 11 Mar 2010 15:39:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type:content-transfer-encoding; bh=wFlXpw30+4IMGOBFqzWabfrEkyiBf1ATIp84yfBVt0M=; b=TxO0ZdTnODwyzy3lg05cJMEn/KGlOl3XEfIUfvshK9zECc57H4b5VzIMYwBmAkz2AO cx4Nllrt2ROHOsucsRbfqgqNwe4ul0+qr/le+ZQe3TTmDFn/XITxLoEO7sKEsZDgZNNp XXHM8LwlKIPU1cmdaD9QGkpfvbg7/LPTPW7Vc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=mQFM3k85IPGRINKj4LFe0bFuI78tz6UOW3hpCxYR0Lkvs8670adofAAwknzGi94VrO YzvWCQXISnraMmav7Qcknq/Jxun6v1nrY98mchMshkziNiIC8GkAIzE1BMmk7cMejxpA BudlmBTqTN9UVNNFUwV2DVaSaV+1YiIcc9NB4= MIME-Version: 1.0 Sender: tomelite82@gmail.com Received: by 10.220.128.16 with SMTP id i16mr421657vcs.0.1268350795247; Thu, 11 Mar 2010 15:39:55 -0800 (PST) In-Reply-To: References: <201003111756.o2BHukJu042449@svn.freebsd.org> <9ace436c1003111530s3bd0de9cq451671909fb6aa64@mail.gmail.com> Date: Thu, 11 Mar 2010 15:39:55 -0800 X-Google-Sender-Auth: 2e6197f628b303ce Message-ID: <9ace436c1003111539t2af8439cn315c695d4b90e28d@mail.gmail.com> From: Qing Li To: Juli Mallett Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Robert Watson Subject: Re: svn commit: r205024 - head/sys/net X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Mar 2010 23:39:57 -0000 I guess it's a good time to clean things up. The if_link_state code has bee= n around for quite some time, either it be fully utilized or not be there at = all. The inconsistency is the root cause. I will try going through these tonight and hopefully the fix all take a common approach. -- Qing On Thu, Mar 11, 2010 at 3:35 PM, Juli Mallett wrote: > On Thu, Mar 11, 2010 at 15:30, Qing Li wrote: >>> >>> A couple of questions: >>> >>> (1) It used to be the case that quite a few interface drivers and types >>> didn't have a notion of "link up" -- especially older ethernet devices.= =A0Do >>> those all have the same problem? =A0It was probably a design oversight = that >>>=A0devices don't declare an explicit capability for "can report link sta= te". >>> >> >> =A0What you raised is definitely a possibility and these fixes take the >> =A0similar approach. I am going to try and go through each of these >> =A0drivers in /sys/dev/ and converting them, very soon. > > Go through drivers in the embedded port directories, too. =A0The Octeon > port's Ethernet driver was broken by this, and it looks like the > Atheros if_arge is probably broken, too. =A0I would even suggest going > back to the old behavior briefly while the port maintainers are given > an opportunity to update their drivers. =A0Actually, it looks like only > MIPS has Ethernet drivers outside of dev/ at a quick glance, but I'd > be surprised if there weren't other broken examples. > > Juli. >