Date: Thu, 11 Mar 2010 15:39:55 -0800 From: Qing Li <qingli@freebsd.org> To: Juli Mallett <jmallett@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Robert Watson <rwatson@freebsd.org> Subject: Re: svn commit: r205024 - head/sys/net Message-ID: <9ace436c1003111539t2af8439cn315c695d4b90e28d@mail.gmail.com> In-Reply-To: <eaa228be1003111535s12febe62x91124b0a015fd0ff@mail.gmail.com> References: <201003111756.o2BHukJu042449@svn.freebsd.org> <alpine.BSF.2.00.1003112128020.97017@fledge.watson.org> <9ace436c1003111530s3bd0de9cq451671909fb6aa64@mail.gmail.com> <eaa228be1003111535s12febe62x91124b0a015fd0ff@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
I guess it's a good time to clean things up. The if_link_state code has bee= n around for quite some time, either it be fully utilized or not be there at = all. The inconsistency is the root cause. I will try going through these tonight and hopefully the fix all take a common approach. -- Qing On Thu, Mar 11, 2010 at 3:35 PM, Juli Mallett <jmallett@freebsd.org> wrote: > On Thu, Mar 11, 2010 at 15:30, Qing Li <qingli@freebsd.org> wrote: >>> >>> A couple of questions: >>> >>> (1) It used to be the case that quite a few interface drivers and types >>> didn't have a notion of "link up" -- especially older ethernet devices.= =A0Do >>> those all have the same problem? =A0It was probably a design oversight = that >>>=A0devices don't declare an explicit capability for "can report link sta= te". >>> >> >> =A0What you raised is definitely a possibility and these fixes take the >> =A0similar approach. I am going to try and go through each of these >> =A0drivers in /sys/dev/ and converting them, very soon. > > Go through drivers in the embedded port directories, too. =A0The Octeon > port's Ethernet driver was broken by this, and it looks like the > Atheros if_arge is probably broken, too. =A0I would even suggest going > back to the old behavior briefly while the port maintainers are given > an opportunity to update their drivers. =A0Actually, it looks like only > MIPS has Ethernet drivers outside of dev/ at a quick glance, but I'd > be surprised if there weren't other broken examples. > > Juli. >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9ace436c1003111539t2af8439cn315c695d4b90e28d>