From owner-p4-projects@FreeBSD.ORG  Thu Nov  2 11:23:15 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 98A5A16A407; Thu,  2 Nov 2006 11:23:15 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 72C5E16A417;
	Thu,  2 Nov 2006 11:23:15 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
Received: from swip.net (mailfe08.swip.net [212.247.154.225])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 793DE43DB9;
	Thu,  2 Nov 2006 11:23:11 +0000 (GMT)
	(envelope-from hselasky@c2i.net)
X-T2-Posting-ID: gvlK0tOCzrqh9CPROFOFPw==
X-Cloudmark-Score: 0.000000 []
Received: from [193.216.90.149] (HELO [10.0.0.249])
	by mailfe08.swip.net (CommuniGate Pro SMTP 5.0.8)
	with ESMTP id 313844656; Thu, 02 Nov 2006 12:23:09 +0100
From: Hans Petter Selasky <hselasky@c2i.net>
To: John Baldwin <jhb@freebsd.org>
Date: Thu, 2 Nov 2006 12:22:46 +0100
User-Agent: KMail/1.7
References: <200611010112.kA11C1Jt066210@repoman.freebsd.org>
	<200611011047.07627.jhb@freebsd.org>
In-Reply-To: <200611011047.07627.jhb@freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200611021222.48108.hselasky@c2i.net>
Cc: Perforce Change Reviews <perforce@freebsd.org>,
	Scott Long <scottl@freebsd.org>
Subject: Re: PERFORCE change 108878 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Nov 2006 11:23:15 -0000

On Wednesday 01 November 2006 16:47, John Baldwin wrote:
> On Tuesday 31 October 2006 20:12, Scott Long wrote:
> > http://perforce.freebsd.org/chv.cgi?CH=108878
> >
> > Change 108878 by scottl@scottl-x64 on 2006/11/01 01:11:30
> >
> >  For some wonderful reason, you cannot pass &Giant to msleep.  Work
> >  around that in a crude fashion.  Also add some more assertions.
>
> Ah, yes, that would be most unhappy.  I guess mostly the idea is that Giant
> should be rather implicit and explicitly using Giant for an object lock is
> discouraged.  I'm not sure that is what you are doing though.  I think
> maybe you are borrowing Giant that's already held?

I use this patch:

/* preliminary fix for a bug in msleep on FreeBSD, 
 * which cannot sleep with Giant:
 */
#define msleep(i,m,p,w,t) msleep(i,(((m) == &Giant) ? NULL : (m)),p,w,t)

Really this issue should be fixed. It happens just because GIANT_DROP is done 
too early in "msleep()".

--HPS