From owner-freebsd-wireless@FreeBSD.ORG Thu Oct 24 00:43:31 2013 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 4A38C3E3 for ; Thu, 24 Oct 2013 00:43:31 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-qe0-x22e.google.com (mail-qe0-x22e.google.com [IPv6:2607:f8b0:400d:c02::22e]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 0BB802CE1 for ; Thu, 24 Oct 2013 00:43:30 +0000 (UTC) Received: by mail-qe0-f46.google.com with SMTP id s14so1025360qeb.33 for ; Wed, 23 Oct 2013 17:43:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=eXPg32tCmUA5Qudj/m1H5MG/P7XNCkudauuIsJg4Gb4=; b=uAnQGXfj4kIUuoU6i2bWuV9cK0hkQPnX9eYCtXs+d5xmXbrqnnfNfLx4XZf5ItundF DTEx2IxfsU5q+/bexumFYf1BA+48P9P4bExKjvhPiVdC4WJ2XN3cOm9J3TQIU9JPZRN/ Ws8kNpDBehen4X6IzZwsCe8aNuiTc65SUy2R2wEYq2/KkB2G3NpxCUE8jQlfhXuwaELd jJPQ+gcsb3/4CurflrQsWwsV6Pg7RfWC3hjO2zOw0oTYIyIkZogredMEnhTjAB1S0h/q yG2jDiL5emwJxdEM7dtju9wfmtf7IaSFzU2RU6R3lpGtxCZk2+s7xt+VDdKDnHHIxlui qbbw== MIME-Version: 1.0 X-Received: by 10.49.127.179 with SMTP id nh19mr59524qeb.1.1382575410189; Wed, 23 Oct 2013 17:43:30 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.224.207.66 with HTTP; Wed, 23 Oct 2013 17:43:30 -0700 (PDT) In-Reply-To: <002701cebc6f$634c0040$29e400c0$@info> References: <002701cebc6f$634c0040$29e400c0$@info> Date: Wed, 23 Oct 2013 17:43:30 -0700 X-Google-Sender-Auth: gmXeZEutfZTS7IGxZtiAopor73k Message-ID: Subject: Re: [IWN] Review From: Adrian Chadd To: Cedric GROSS Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: "freebsd-wireless@freebsd.org" X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Oct 2013 00:43:31 -0000 Hi, Ok. I've reviewed this stuff in more depth. Split-6 is still way too big to commit as one commit. I was also hoping that we could get the updated hardware support into this without necessarily adding the PAN support. But, you're the one driving this, so it's up to you. :) * There's DPRINTF() and the debug flags that you've moved into if_iwnreg.h, which is the wrong place for it! * .. same as iwn_intr_str() * You still have style(9) issues: + the "if" constructs should be if (), not if(); + you need spaces between things - eg, if (a == b) rather than if(a==b) or if (a==b); + the } else { should be on one line, not separate on multiple lines. * What's the story behind sc->ctx? When is it being set/changed? * And then there's also ivp->ctx; that's the current VAP context, right? If that's the case ,why are we bothering checking unit number? Why don't we consistently check the vap context? So, let's break up split_6 into this: * create if_iwn_debug.h; put the debug macros, enum and such into that; * submit a patch _just_ for the debug work, that's easy to do. * Then, fix up the style(9) issues. * Then, help me figure out what the story is with sc->ctx so I understand what's going on there. I'd like to try and remove that if possible. Thanks, -adrian On 28 September 2013 10:23, Cedric GROSS wrote: > Hello, > > > > I'm get some free time. So I setted up my github for split work. > > > > So on https://github.com/KreizIT/FreeBSD-IWN/ > > > > You will find 2 new branch : split_6 and split_7. > > > > Split_6 is iwn -HEAD with split 6 applied. Patch for that is also available > in this branch. > > Split_7 is iwn -HEAD with split 6 and new split 7 applied. > > > > Split_7 start "parameters task". So no massive change except that it's > manage NIC without BT. > > > > Regards > > Cedric > > _______________________________________________ > freebsd-wireless@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-wireless > To unsubscribe, send any mail to "freebsd-wireless-unsubscribe@freebsd.org > " >