Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 14 Sep 2020 22:22:42 +0200
From:      Emmanuel Vadot <manu@bidouilliste.com>
To:        Jan Beich <jbeich@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r548253 - in head/graphics: . glx-utils mesa-demos
Message-ID:  <20200914222242.507a38256bbaf622cd85fcb4@bidouilliste.com>
In-Reply-To: <lfhc-dxvi-wny@FreeBSD.org>
References:  <202009111728.08BHShvE009018@repo.freebsd.org> <20200914164152.fe53cfb4b24b1d184e646c0f@bidouilliste.com> <lfhc-dxvi-wny@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 14 Sep 2020 20:19:45 +0200
Jan Beich <jbeich@FreeBSD.org> wrote:

> Emmanuel Vadot <manu@bidouilliste.com> writes:
> 
> > On Fri, 11 Sep 2020 17:28:43 +0000 (UTC)
> > Jan Beich <jbeich@FreeBSD.org> wrote:
> >
> >> Author: jbeich
> >> Date: Fri Sep 11 17:28:43 2020
> >> New Revision: 548253
> >> URL: https://svnweb.freebsd.org/changeset/ports/548253
> >> 
> >> Log:
> >>   graphics/glx-utils: add new port
> >>   
> >>   A few popular OpenGL X11 demos from Mesa:
> >>   
> >>   - glxinfo prints capabilities of OpenGL driver
> >>   - glxgears draws rotating gears and prints FPS
> >>   
> >>   Inspired by:	D26077, glx-utils (CentOS, PkgSrc), glxinfo (AUR, MacPorts, Nix)
> >>   Motivated by:	testing GLX on Xwayland, avoiding cruft and extra deps
> >> 
> >> Added:
> >>   head/graphics/glx-utils/
> >>   head/graphics/glx-utils/Makefile   (contents, props changed)
> >>   head/graphics/glx-utils/distinfo   (contents, props changed)
> >>   head/graphics/glx-utils/pkg-descr   (contents, props changed)
> >> Modified:
> >>   head/graphics/Makefile   (contents, props changed)
> >>   head/graphics/mesa-demos/Makefile   (contents, props changed)
> >> 
> >
> >  Saw this commit on Friday evening and decided to not answer as I
> > wanted to spend a nice weekend.
> >  Now that I'm back, what the fuck ? Seriously what the fuck ?
> >
> >  You see a review where a commiter start to address a problem, decide
> > that it's not the right way to do it and instead of talking to him you
> > just commit your way of solving the problem ?
> >  And now we're suppose to adapt to your way of handling this problem
> > without prior discussion ?
> >  It's freebsd-ports, not jbeich-ports.
> 
> D26077 didn't have feedback for ~1 month.

 Maybe because Tobias spent the last few weeks fixing -fno-common for a
lot of ports ?

>  I've added glx-utils mainly for myself (see Motivated by) after analyzing prior art. Why do I need
> to justify every port for you? 

 This is not about justifying to me but to all ports commiters, again
the ports tree isn't yours.

> If you don't like the approach disapprove/reject patches touching your or x11@ ports.
> 
> Please, blame me for regressions or more work instead.

 This is not how the ports tree is supposed to work.

> >  I still don't understand that you're not willing to send a email
> > stating your plan before commiting stuff. There was no hurry in
> > commiting this without prior discussion. This is not the first time
> > that you do that and you still don't understand.
> 
> Burnout and non-zero backlog. For example, I wouldn't have worked on
> improving mesa-demos even if the planning decided creating a separate
> port wasn't a good idea. For unrelated example, planning didn't help D25020.

 If you're burnt out stop commiting things.

> >  It's really demotivating *not* working with you.
> 
> Sorry, I don't like close cooperation. Collaborating on a common goal is
> fine but if you want to micromanage maybe just do the work yourself.

 This is not about micromanage for fuck sake, if you don't like
cooperation don't bother commit to something handled by multiple
persons.

-- 
Emmanuel Vadot <manu@bidouilliste.com>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200914222242.507a38256bbaf622cd85fcb4>