From nobody Wed Jun 10 04:01:10 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gZsX72KgZz6gvX7 for ; Wed, 10 Jun 2026 04:01:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gZsX66y4Lz3wGk for ; Wed, 10 Jun 2026 04:01:10 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1781064071; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QF8lLSfRPZvN9j7j0gqtfuKXzFN+eJYq1UwaqmRAEVM=; b=t0mfoNiZRz+Pnjivf6N1VHCG9TSHVFgZzwDSs3yGe5cI91ei4B1n5VyNeS8UOyp5bN03NX Q+p6AhJ9zCUwgfjSgdTpl1jqYti26zze+HsWw2BcFX2Ya8WVer9KDhRZzzZ31iHWrGnCVG LjfxeyzG25Ef7YoGXoX8SISWrDt3v0fCPZMg9nDQNVcib/Ww07KPxBbYlw8B/CBzEcIRzb ux7dE3MhgLdw8jjmcE9rFGDKYWWs9r1i7D0CQZ3r58i4lA2J238QEPtHoykqDs0sTf8ieK NYIg7ZckFGUFLV9+HgaPcd5OddZ9qqgPlXCnlwKHiDQaUh98HSWRMOMm27347g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1781064071; a=rsa-sha256; cv=none; b=lUnIPKPkxsPvzuWOsII5t207Em027Y46XTkgqbS6lLX90IvXICGUx6fwrzxjg+zy6Y8Q+t GRe8kJiJ7WljkPuvZtK4em4n8fXz558vXutb1LP8eIog5i2zf4gtz1K9kr8NVydvuiTmgw N+xIspIxt2l05oTh56F21CRfUuiybjeXnxobVMJtpDfsrxTn/+dCpJEmU7jKBUEDjK9HM/ HeNRKo5QehZMRo9T237Z9b0PkoVe+rtw6d/aIwDh2JJm77HM+ndeh/UwS0zY+I9NW35Ma4 jBQMWPzKJCRxpqSJ+Y+vBUfv3jOUjLVWpZk31mKsmYjWRzZZvmoHD5pO1zgEmA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1781064071; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QF8lLSfRPZvN9j7j0gqtfuKXzFN+eJYq1UwaqmRAEVM=; b=EJUqgvs6OnjBuhEG5CwB3V4ysfJbYZf7zurybP9VoOVbiBeh+UcJ+Bmog/cbHIUpHQ3O9b L6tERYWLpw0WFFFct9dQ9iEha3puq7b2JgbY6K8lL+WYgFa+IhL1y86MOcjwH7FbpTKnvj uWU0bElhbe36z/b6N3wfF2ogXP4wTdCBT6t2OL/CKLk31FaoozNSOkTrzKfrjuLv2Lir+R n+mzL9n3lUBm+z/V+i0yBln9UyJSveQMweNzW3D99mU24slHd9Jf5jeCwyVYjEcEp4EIl1 0msif67Nuw+5V208tGKsSF7XCbVTnLz8PhUHiXszMbouS5KmBEL7Aaar0AMOug== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gZsX66WBcz143B for ; Wed, 10 Jun 2026 04:01:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 264d0 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 10 Jun 2026 04:01:10 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Chris Longros From: Kyle Evans Subject: git: 2edb8d4f60cd - stable/15 - cron: log when a crontab path is too long List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kevans X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 2edb8d4f60cd66979c0b8a76c2ccbc33dac462ad Auto-Submitted: auto-generated Date: Wed, 10 Jun 2026 04:01:10 +0000 Message-Id: <6a28e186.264d0.44a55788@gitrepo.freebsd.org> The branch stable/15 has been updated by kevans: URL: https://cgit.FreeBSD.org/src/commit/?id=2edb8d4f60cd66979c0b8a76c2ccbc33dac462ad commit 2edb8d4f60cd66979c0b8a76c2ccbc33dac462ad Author: Chris Longros AuthorDate: 2026-04-29 04:06:29 +0000 Commit: Kyle Evans CommitDate: 2026-06-10 04:00:35 +0000 cron: log when a crontab path is too long Log via syslog when snprintf truncates the crontab path, instead of silently skipping the entry. Signed-off-by: Christos Longros Reviewed by: bcr, kevans (cherry picked from commit 91bfba010bcda665cc24a76af631cc85fcb0c688) --- usr.sbin/cron/cron/cron.8 | 11 +++++++++-- usr.sbin/cron/cron/database.c | 6 ++++-- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/usr.sbin/cron/cron/cron.8 b/usr.sbin/cron/cron/cron.8 index 23a295393df5..f1a6a30d4cb5 100644 --- a/usr.sbin/cron/cron/cron.8 +++ b/usr.sbin/cron/cron/cron.8 @@ -19,7 +19,7 @@ .\" .\" $Id: cron.8,v 1.2 1998/08/14 00:32:36 vixie Exp $ .\" -.Dd January 20, 2026 +.Dd April 29, 2026 .Dt CRON 8 .Os .Sh NAME @@ -227,7 +227,14 @@ configuration file for .It Pa /usr/local/etc/cron.d Directory for third-party package provided crontab files. .It Pa /var/cron/tabs -Directory for personal crontab files +Directory for personal crontab files. +Internally the daemon constructs the relative path +.Pa tabs/ Ns Ar filename , +which must fit within +.Dv MAXNAMLEN +bytes; in practice this allows filenames up to 250 bytes. +Longer entries are skipped and a diagnostic is logged via +.Xr syslog 3 . .El .Sh SEE ALSO .Xr crontab 1 , diff --git a/usr.sbin/cron/cron/database.c b/usr.sbin/cron/cron/database.c index 35e5fad3524d..234b5ef7fdd6 100644 --- a/usr.sbin/cron/cron/database.c +++ b/usr.sbin/cron/cron/database.c @@ -166,8 +166,10 @@ load_database(cron_db *old_db) fname[sizeof(fname)-1] = '\0'; if (snprintf(tabname, sizeof tabname, CRON_TAB(fname)) - >= sizeof(tabname)) - continue; /* XXX log? */ + >= (int)sizeof(tabname)) { + log_it("CRON", getpid(), "TABNAME TOO LONG", fname); + continue; + } process_crontab(fname, fname, tabname, &statbuf, &new_db, old_db);