From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Sep 10 02:26:26 2014 Return-Path: Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D51531AA for ; Wed, 10 Sep 2014 02:26:26 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A0F21C26 for ; Wed, 10 Sep 2014 02:26:26 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id s8A2QQOD017946 for ; Wed, 10 Sep 2014 02:26:26 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 181301] [NEW PORT] net/kamailio: Very fast and configurable open source SIP proxy Date: Wed, 10 Sep 2014 02:26:26 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports Tree X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-qa, patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: olivermahmoudi@gmail.com X-Bugzilla-Status: Open X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Sep 2014 02:26:26 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D181301 --- Comment #13 from olivermahmoudi@gmail.com --- (In reply to John Marino from comment #11) > (In reply to olivermahmoudi from comment #10) >=20 > > 5) XPLIST_SUB+=3D MYSQL=3D"" > > X.else > > XPLIST_SUB+=3D MYSQL=3D"@comment " > >=20 > > This is ancient use of options, use the new OPTIONS_SUB please (review > > porters handbook on OPTIONS) > >=20 > > The program's configure stage is non standard and options are passed on= a > > pre-build stage to prepare the built. Checked back on this issued with = the > > ports mailing list. Their feedback was that it is still OK to keep it t= hat=20 > > way since the new way of setting up the options won't solve my special > > scenario here. >=20 > Well, except OPTIONS_SUB affects PLIST_SUB and not configure arguments. I > was objecting to your (ancient) brute force definitions of "" and "@comme= nt > " which is unnecessary with OPTIONS_SUB If what you are talking about is this: ### Version 1=20 .if ${PORT_OPTIONS:MMYSQL} BUILD_DEPENDS+=3D ${LOCALBASE}/libexec/mysqld:${PORTSDIR}/databases/mysql56-server RUN_DEPENDS+:=3D ${BUILD_DEPENDS} EXTRA_MODULES+=3D db_mysql PLIST_SUB+=3D MYSQL=3D"" .else PLIST_SUB+=3D MYSQL=3D"@comment " .endif ### Version 2 OPTIONS_SUB=3Dyes .if ${PORT_OPTIONS:MMYSQL} BUILD_DEPENDS+=3D ${LOCALBASE}/libexec/mysqld:${PORTSDIR}/databases/mysql56-server RUN_DEPENDS+:=3D ${BUILD_DEPENDS} EXTRA_MODULES+=3D db_mysql .endif whereas: Version 1 =3D=3D Version 2 then I can see what you mean and could update things to Version 2 via OPTIONS_SUB. What I would essentially be carving out is this bit: PLIST_SUB+=3D MYSQL=3D"" .else PLIST_SUB+=3D MYSQL=3D"@comment " and it would still work. Is this the point you were trying to make? --=20 You are receiving this mail because: You are the assignee for the bug.=