From owner-freebsd-hackers@FreeBSD.ORG Sat Jul 2 15:25:58 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B3F8A106566C for ; Sat, 2 Jul 2011 15:25:58 +0000 (UTC) (envelope-from kaduk@mit.edu) Received: from dmz-mailsec-scanner-8.mit.edu (DMZ-MAILSEC-SCANNER-8.MIT.EDU [18.7.68.37]) by mx1.freebsd.org (Postfix) with ESMTP id 677DC8FC08 for ; Sat, 2 Jul 2011 15:25:58 +0000 (UTC) X-AuditID: 12074425-b7b82ae000000a2a-6e-4e0f385f3b89 Received: from mailhub-auth-4.mit.edu ( [18.7.62.39]) by dmz-mailsec-scanner-8.mit.edu (Symantec Messaging Gateway) with SMTP id AD.86.02602.F583F0E4; Sat, 2 Jul 2011 11:25:19 -0400 (EDT) Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id p62FPvhP014916; Sat, 2 Jul 2011 11:25:57 -0400 Received: from multics.mit.edu (MULTICS.MIT.EDU [18.187.1.73]) (authenticated bits=56) (User authenticated as kaduk@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id p62FPtxE028843 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 2 Jul 2011 11:25:57 -0400 (EDT) Received: (from kaduk@localhost) by multics.mit.edu (8.12.9.20060308) id p62FPtTr000154; Sat, 2 Jul 2011 11:25:55 -0400 (EDT) Date: Sat, 2 Jul 2011 11:25:55 -0400 (EDT) From: Benjamin Kaduk To: Robert Millan In-Reply-To: Message-ID: References: User-Agent: Alpine 1.10 (GSO 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrFIsWRmVeSWpSXmKPExsUixG6nrhtvwe9nsPeWnsX2zf8YLbbcn8bk wOTxq20us8eMT/NZApiiuGxSUnMyy1KL9O0SuDIunNrFWrCZq2Jn+xnWBsadHF2MnBwSAiYS X29uYYWwxSQu3FvPBmILCexjlPiwW7uLkQvIXs8oMWfpPmYIZz+TxOSnG9ghquolri2Yy9TF yMHBIqAlsfWiCkiYTUBFYuabjWCDRASUJDav2gRmMwvIS1zYfIgRpFxYQF/iciNYmFMgUOJg 5yywG3gFHCQWLzvKCjE9QGLSmklgm0QFdCRW75/CAlEjKHFy5hMWiJGWEuf+XGebwCg4C0lq FpLUAkamVYyyKblVurmJmTnFqcm6xcmJeXmpRboWermZJXqpKaWbGMFB6qK6g3HCIaVDjAIc jEo8vD+f8/oJsSaWFVfmHmKU5GBSEuWVAYa4EF9SfkplRmJxRnxRaU5q8SFGCQ5mJRHeblWg HG9KYmVValE+TEqag0VJnDfE+7+vkEB6YklqdmpqQWoRTFaGg0NJglccZKhgUWp6akVaZk4J QpqJgxNkOA/QcGGQGt7igsTc4sx0iPwpRkUpcd5X5kAJAZBERmkeXC8sibxiFAd6RZh3GkgV DzABwXW/AhrMBDQ4M58XZHBJIkJKqoFR0/rH53LtD6ueuVpGNbc/9d3PdU1FVMGs5lv37al1 WgZ8M9+n33N9y1EmF3JpmmfgiiDhV5kPp8X/mPV1dq6jkurrOSWHVA/ccIv4fct2W9ebhxby f6W770yrmtOzmyPpOHNsgtdWk6yODZ4Hcgo3NoUq5X7bfO9E5P4pS1lNbujtiTz0VeOaEktx RqKhFnNRcSIAZ01A6P0CAAA= Cc: freebsd-hackers@freebsd.org Subject: Re: [PATCH] Remove -nostdinc in aicasm X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Jul 2011 15:25:58 -0000 On Sat, 2 Jul 2011, Robert Millan wrote: > The userland aicasm utility in sys/dev/aic7xxx/aicasm/Makefile is being > built with "-nostdinc -I/usr/include" options. Unfortunately this breaks > building aicasm on systems using the upstream version of GCC, where > "-nostdinc" disables more search directories than are enabled by > "-I/usr/include". There is a functional difference between '-nostdinc -I/usr/include -I.' even when the standard include search path is just /usr/include -- the standard include paths are always searched last (unless -nostdinc is given), even if they are explicitly listed on the command line. If there are conflicting definitions in /usr/local/foo.h and ./foo.h, this gimmick can be necessary to pull in the correct version. (I've needed to do this when packaging software for the freebsd ports collection, though with /usr/local/include replacing '.'.) I have not checked whether this affects aicasm, though (which may or may not manifest itself as compiler warnings). -Ben Kaduk > > This was introduced by obrien (CCed) in 2002, apparently to remove a > warning. I've verified that removing it doesn't produce any warnings > on FreeBSD 9-CURRENT environment. > > Please consider this patch to remove -nostdinc in that file. > > -- > Robert Millan >