From owner-cvs-ports@FreeBSD.ORG  Fri Jun 15 18:39:58 2007
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
X-Original-To: cvs-ports@freebsd.org
Delivered-To: cvs-ports@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
	id CD85D16A469; Fri, 15 Jun 2007 18:39:58 +0000 (UTC)
Date: Fri, 15 Jun 2007 18:39:58 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: infofarmer@FreeBSD.org
Message-ID: <20070615183958.GA1681@FreeBSD.org>
References: <200706151800.l5FI0BZD087745@repoman.freebsd.org>
	<20070615180818.EEBAE16A484@hub.freebsd.org>
	<cb5206420706151130v7a5e687g31cfeac49f2ca1ab@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <cb5206420706151130v7a5e687g31cfeac49f2ca1ab@mail.gmail.com>
User-Agent: Mutt/1.4.2.1i
Cc: cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org
Subject: Re: cvs commit: ports/graphics/sng Makefile pkg-descr
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Jun 2007 18:39:58 -0000

On Fri, Jun 15, 2007 at 10:30:34PM +0400, Andrew Pantyukhin wrote:
> On 6/15/07, Alexey Dokuchaev <danfe@freebsd.org> wrote:
> >danfe       2007-06-15 18:00:11 UTC
> >
> >  FreeBSD ports repository
> >
> >  Modified files:
> >    graphics/sng         Makefile pkg-descr
> >  Log:
> >  - Fix the build with recent GCC [1]
> >  - Correctly assign RUN_DEPENDS
> >  - Minor indentation nit in Makefile
> >  - Kill EOL space in pkg-descr
> >
> >  Reported by:    pointyhat (logs) [1]
> >
> >  Revision  Changes    Path
> >  1.13      +3 -2      ports/graphics/sng/Makefile
> >  1.2       +1 -1      ports/graphics/sng/pkg-descr
> >_______________________________________________
> > pre-patch:
> >        @${REINPLACE_CMD} -e 's|-static||g' ${WRKSRC}/Makefile.in
> >+       @${REINPLACE_CMD} -e '33,34s|^static ||' ${WRKSRC}/sngd.c
> 
> I'd warn you against these numbered sed substitutions.
> For one, they're hard to maintain. They also can cause
> silent damage to sources which is very hard to track.

Well, since (luckily for us!) our REINPLACE_CMD implementation leaves
.bak-files, it is really not that hard to run diff(1) over them.

> 
> In this very case, it use this:
> '/^static png_/s|^static ||'

I'd buy your reasoning here.  It's just that I love sed(1)+conciseness too
freaking much :-) and want to avoid adding trivial patch files.

I'll try to think more about my regexps next time, thanks!

./danfe