From owner-freebsd-threads@FreeBSD.ORG Sat Feb 5 09:58:16 2011 Return-Path: Delivered-To: freebsd-threads@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1AAAC1065670; Sat, 5 Feb 2011 09:58:16 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 8511A8FC13; Sat, 5 Feb 2011 09:58:14 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id p159wATN003430 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 5 Feb 2011 11:58:10 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4) with ESMTP id p159wAKE086165; Sat, 5 Feb 2011 11:58:10 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4/Submit) id p159wAEr086164; Sat, 5 Feb 2011 11:58:10 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 5 Feb 2011 11:58:10 +0200 From: Kostik Belousov To: Jung-uk Kim Message-ID: <20110205095810.GW78089@deviant.kiev.zoral.com.ua> References: <201102041409.12314.jkim@FreeBSD.org> <20110204213302.GS78089@deviant.kiev.zoral.com.ua> <201102050224.23377.jkim@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="YwTTlJgQ7QoYB9ta" Content-Disposition: inline In-Reply-To: <201102050224.23377.jkim@FreeBSD.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-3.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, DNS_FROM_OPENWHOIS autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: davidxu@freebsd.org, freebsd-threads@freebsd.org Subject: Re: [RFC] Implement pthread_getthreadid_np(3) and pthread_getunique_np(3) X-BeenThere: freebsd-threads@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Threading on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Feb 2011 09:58:16 -0000 --YwTTlJgQ7QoYB9ta Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Feb 05, 2011 at 02:24:09AM -0500, Jung-uk Kim wrote: > On Friday 04 February 2011 04:33 pm, Kostik Belousov wrote: > > On Fri, Feb 04, 2011 at 02:09:10PM -0500, Jung-uk Kim wrote: > > > Our pthread_t is not an integral type and it causes a lot of > > > trouble porting some software, which relies on Linux's gettid() > > > or similar syscalls: > > > > > > http://www.kernel.org/doc/man-pages/online/pages/man2/gettid.2.ht > > >ml > > > > > > For example: > > > > > > http://docs.freebsd.org/cgi/mid.cgi?201102032111.13479.jkim > > > > > > To solve this problem, I implemented two functions: > > > > > > http://people.freebsd.org/~jkim/thr_tid.diff > > > > > > Basically, they are AIX's pthread_getthreadid_np(3) and > > > pthread_getunique_np(3) look-alikes: > > > > > > http://publib.boulder.ibm.com/infocenter/iseries/v5r4/topic/apis/ > > >users_22.htm > > > http://publib.boulder.ibm.com/infocenter/iseries/v5r4/topic/apis/ > > >users_23.htm > > > > > > Please let me know what you think. > > > > Why do you need new functions available in stubs ? >=20 > Oops, my bad. Fixed: >=20 > http://people.freebsd.org/~jkim/thr_tid2.diff >=20 > > Also, would it be better to return proper id even if threading is > > not initialized, instead of EINVAL ? >=20 > Because I want it to be fast and cause no side-effect, no. You can allocate static lwpid_t self_tid variable, and in case threading is not initialized yet, and self_tid =3D=3D 0, do self_tid =3D thr_self(). Otherwise, if threading is initialized and self_tid !=3D 0, return self_tid. BTW, what should be the behaviour of new functions after fork() ? Is it undefined ? --YwTTlJgQ7QoYB9ta Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEARECAAYFAk1NHzIACgkQC3+MBN1Mb4hANQCggxqO4lEtAOGtp8bWXMVjsVHH 5r8AoIF4wUEn/eW9sLCo+PSne4q59WLO =KsB9 -----END PGP SIGNATURE----- --YwTTlJgQ7QoYB9ta--