From owner-svn-src-head@FreeBSD.ORG  Thu May 16 21:29:52 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id CF246783;
 Thu, 16 May 2013 21:29:52 +0000 (UTC)
 (envelope-from julian@freebsd.org)
Received: from vps1.elischer.org (vps1.elischer.org [204.109.63.16])
 by mx1.freebsd.org (Postfix) with ESMTP id A598E818;
 Thu, 16 May 2013 21:29:52 +0000 (UTC)
Received: from Julian-MBP3.local ([137.122.64.21]) (authenticated bits=0)
 by vps1.elischer.org (8.14.5/8.14.5) with ESMTP id r4GLTn4q020032
 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO);
 Thu, 16 May 2013 14:29:49 -0700 (PDT)
 (envelope-from julian@freebsd.org)
Message-ID: <51954FC8.7040502@freebsd.org>
Date: Thu, 16 May 2013 17:29:44 -0400
From: Julian Elischer <julian@freebsd.org>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8;
 rv:17.0) Gecko/20130509 Thunderbird/17.0.6
MIME-Version: 1.0
To: Julian Elischer <julian@freebsd.org>
Subject: Re: svn commit: r250700 - in head/sys: conf net netinet6 sys
References: <201305161620.r4GGKIFI012296@svn.freebsd.org>
 <CAJOYFBBdGSz2n0R6e6TrCKsxc-N8nP41WyZ3GWD7EPmva_CSwg@mail.gmail.com>
 <51954C96.3060409@freebsd.org>
In-Reply-To: <51954C96.3060409@freebsd.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, Ed Schouten <ed@80386.nl>,
 svn-src-all@freebsd.org, src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 16 May 2013 21:29:52 -0000

On 5/16/13 5:16 PM, Julian Elischer wrote:
> On 5/16/13 3:19 PM, Ed Schouten wrote:
>> Hey Julian,
>>
>> 2013/5/16 Julian Elischer <julian@freebsd.org>:
>>>   #define M_SETFIB(_m, _fib) do 
>>> {                                                \
>>> -       _m->m_flags &= 
>>> ~M_FIB;                                          \
>>> -       _m->m_flags |= (((_fib) << M_FIBSHIFT) & M_FIB);  \
>>> +        KASSERT((_m)->m_flags & M_EXT, ("No FIB on non header 
>>> mbuf")); \
>>> +       ((_m)->m_pkthdr.fibnum) = 
>>> (_fib);                               \
>>>   } while (0)
>> This KASSERT triggers on my box at home. Sorry, but busy right now, so
>> I can't spend too much time debugging this. Right after getting a
>> DHCPACK on bootup, the box panics. Copied by hand:
>
> thanks
> My face is red because while this indicates a bug in someone else's 
> code, I should
> have caught it myself.. but guess what?   I accidentally turned off 
> invariants.. duh!
>
> I will track down the  errant code and fix..

red face....    note the cut-n-paste error above..  M_EXT should be 
M_PKTHDR

see correcting commit

>
> Julian
>
> \
>
>