From owner-cvs-all  Sat Mar  3  0:22: 2 2001
Delivered-To: cvs-all@freebsd.org
Received: from blizzard.sabbo.net (ns.sabbo.net [193.193.218.18])
	by hub.freebsd.org (Postfix) with ESMTP
	id 0746C37B718; Sat,  3 Mar 2001 00:21:47 -0800 (PST)
	(envelope-from max@vic.sabbo.net)
Received: from vic.sabbo.net (root@vic.sabbo.net [193.193.218.112])
	by blizzard.sabbo.net (8.10.1/8.10.1) with ESMTP id f238Lei18873;
	Sat, 3 Mar 2001 10:21:42 +0200
Received: (from max@localhost)
	by vic.sabbo.net (8.11.2/8.11.2) id f238Lgf69187;
	Sat, 3 Mar 2001 10:21:42 +0200 (EET)
	(envelope-from sobomax@FreeBSD.org)
From: Maxim Sobolev <sobomax@FreeBSD.org>
Message-Id: <200103030821.f238Lgf69187@vic.sabbo.net>
Subject: Re: cvs commit: ports/audio/mpg123 Makefile ports/audio/mpg123/files
To: kris@FreeBSD.org (Kris Kennaway)
Date: Sat, 3 Mar 2001 10:21:16 +0200 (EET)
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
In-Reply-To: <200103030023.f230NE345500@freefall.freebsd.org> from "Kris Kennaway" at Mar 02, 2001 04:23:13 PM
X-Mailer: ELM [version 2.5 PL3]
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

> 
> kris        2001/03/02 16:23:13 PST
> 
>   Modified files:
>     audio/mpg123         Makefile 
>     audio/mpg123/files   patch-ab 
>   Added files:
>     audio/mpg123/files   patch-ae 
>   Log:
>   Switch the ASM selection code to use CPUTYPE on -current, and hence
>   automatically select the correct version without needing to set a
>   non-standard environment variable.
>   Use random() instead of rand() because I'm sick of getting the same songs
>   over and over in shuffle play.
>   Quell a format string warning with -Wnon-const-format
>   Bump PORTREVISION
>   
>   Reviewed by:    maintainer timeout
		    ^^^^^^^^^^^^^^^^^^
It is not true, because:
1. You did not send me random() vs. rand() changes at all;
2. The same is about -Wnon-const-format;
3. About your CPUTYPE request I replied you that this makes impossible to
   use ASM optimisation on anything but very recent -stable and -current.
   AFAIK, ports expected to work at least on wide range  of systems
   between 4.0-RELEASE and pre-CPUTYPE 4-STABLE;
4. In addition you broke the port (<bsd.port.pre.mk> instead of
   <bsd.port.mk>):

/usr/ports/audio/mpg123# make
If you want to compile with ESound support,
hit Ctrl-C right now and use "make WITH_ESOUND=yes"
If you want to compile with NAS support,
hit Ctrl-C right now and use "make WITH_NAS=yes"
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Syntax error: Unterminated quoted string
*** Error code 2

Therefore I demand that you revert CPUTYPE commit, or I will do it by myself.

-Maxim



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message