From owner-freebsd-virtualization@FreeBSD.ORG Sat Dec 28 01:49:17 2013 Return-Path: Delivered-To: virtualization@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6D3C9F8A; Sat, 28 Dec 2013 01:49:17 +0000 (UTC) Received: from mail-qe0-x235.google.com (mail-qe0-x235.google.com [IPv6:2607:f8b0:400d:c02::235]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 1D37312B1; Sat, 28 Dec 2013 01:49:17 +0000 (UTC) Received: by mail-qe0-f53.google.com with SMTP id nc12so9509206qeb.40 for ; Fri, 27 Dec 2013 17:49:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=p88W7+vYGhB33M5C2aG5CVgaCIhm7kZSG7dtE23wmA0=; b=HDS99jUTcpJcTGz247D3SJdNz1JR+QqK8Asq+PfToUWq30G0viiaMF3NYiHUB2iwef QXKBZ66KiJOhuoexCBlknJZWQK9vZEHAa+rZDpMsKrlfZTPFAk9ExmxValYIecSzcdYy pwC1YgBg/2DAU54+8POcx84DYcYmt7YeLOJ3ASYeh7l2NEGxFWMogNT+mIC7pgMraV2F Xn6MEMQtNfgMtmOBZuZNce6YXQZwzvc2VSE7UvggJrvz0Xv79FyYPGwjhl4lr+VzAuKm QjzMB+6jpsToswk6wGixACjeRIcwQXH1pe9JyN6h8BM7P6CeiAn3t5HjiPeOMYGlDZ0q ncJQ== MIME-Version: 1.0 X-Received: by 10.224.97.65 with SMTP id k1mr63563911qan.67.1388195356338; Fri, 27 Dec 2013 17:49:16 -0800 (PST) Received: by 10.140.34.17 with HTTP; Fri, 27 Dec 2013 17:49:16 -0800 (PST) In-Reply-To: <201312271205.54102.jhb@freebsd.org> References: <201312271205.54102.jhb@freebsd.org> Date: Fri, 27 Dec 2013 17:49:16 -0800 Message-ID: Subject: Re: [PATCH] Rework DSDT generation in bhyve From: Neel Natu To: John Baldwin Content-Type: text/plain; charset=ISO-8859-1 Cc: "freebsd-virtualization@freebsd.org" X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Dec 2013 01:49:17 -0000 Hi John, On Fri, Dec 27, 2013 at 9:05 AM, John Baldwin wrote: > While hacking on the power button support, I also started rototilling the DSDT > generation code a bit. My initial goal was to enumerate the LPC serial ports > (COM1 and COM2) properly via ACPI. I ended up doing the following: > > - Moved the info for the top-level PCI bus into the PCI emulation code and > added ResourceProducer entries for the memory ranges decoded by the bus > for memory BARs. > - I added a framework to allow each PCI emulation driver to optionally write > an entry into the DSDT under the \_SB_.PCI0 namespace. The LPC driver uses > this to write a node for the LPC bus (\_SB_.PCI0.ISA). > - I added a linker set to allow any LPC devices to write entries into the > DSDT below the LPC node. I moved the existing block for the RTC out of > acpi.c and into the RTC driver. I added DSDT nodes for the AT PIC, > the 8254 ISA timer, and the LPC UART devices. > - I also added a "SuperIO" device under the LPC node to claim "system > resources" (as is done in real hardware). I added a linker set to allow > various drivers to add IO or memory ranges that should be claimed by > SuperIO and then added the extended RTC IO range and the registers used > for ACPI power management as system resources. > > The end result is that for the stock VM created by vmrun.sh, the attimer0, > uart0, and uart1 devices move from isa0 to acpi0. There is also a PIC > device that would be claimed by 'device atpic' (but the stock amd64 kernel > doesn't include that). The DSDT is also a bit more fleshed out, and also > looks "nice" as devices are mostly laid out in the normal tree rather than > using separate Scope() sections for each device. > > Note that I did add some helper routines for writing out DSDT lines and > resource entries to try to simplify the code in the various DSDT handlers > and make the code that generates DSDT lines a bit more readable (e.g. the > implicit newlines make things more readable IMO). > > The patch is relative to the previous power button patch and is at > http://www.FreeBSD.org/~jhb/patches/bhyve_dsdt.patch I am getting a "404 Not Found" at this URL. best Neel > > Assuming these are ok, the next thing I might work on is cleaning up > the PCI INTx interrupts. They should really all be rounted to the I/O APIC > intpins above 15 (and we should leave ISA IRQs 5, 10, and 11 alone in APIC > mode and only fall back to that if we are using the 8259As and a real ELCR). > The MP Table output would need some minor tweaking for that, and for ACPI we > should generate a _PRT table under _SB_.PCI0 in pci_emul.c. > > -- > John Baldwin > _______________________________________________ > freebsd-virtualization@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-virtualization > To unsubscribe, send any mail to "freebsd-virtualization-unsubscribe@freebsd.org"