From owner-cvs-all Sun Jan 6 19:42:29 2002 Delivered-To: cvs-all@freebsd.org Received: from gw.nectar.cc (gw.nectar.cc [208.42.49.153]) by hub.freebsd.org (Postfix) with ESMTP id 07B6E37B419; Sun, 6 Jan 2002 19:42:25 -0800 (PST) Received: by gw.nectar.cc (Postfix, from userid 1001) id 77BE94; Sun, 6 Jan 2002 21:42:24 -0600 (CST) Date: Sun, 6 Jan 2002 21:42:24 -0600 From: "Jacques A. Vidrine" To: Jeremy Lea , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/net/gnomeicu/files patch-src::icu_db.c Message-ID: <20020106214224.A67906@hellblazer.nectar.cc> Mail-Followup-To: "Jacques A. Vidrine" , Jeremy Lea , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org References: <200201062053.g06KrMC19409@freefall.freebsd.org> <20020106213902.GA88137@madman.nectar.cc> <20020106220536.N73815@squall.waterspout.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20020106220536.N73815@squall.waterspout.com>; from will@csociety.org on Sun, Jan 06, 2002 at 10:05:36PM -0500 X-Url: http://www.nectar.cc/ Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, Jan 06, 2002 at 10:05:36PM -0500, Will Andrews wrote: > It's possible that there is an OS that doesn't have stdlib.h. I highly doubt that is true anymore, particularly where GNOME runs. If you don't have , you are not using C (since 1989 or earlier). > So > autoconf in gnomeicu presumably does a check for it and defines > HAVE_STDLIB_H if it exists. This is the correct fix, if reg@ > wishes to get this merged into GnomeICU sources. No, the correct fix is to have autoconf check for malloc.h, and define HAVE_MALLOC_H if it exists. Or just ignore malloc.h entirely, since there is no malloc.h in any C standard that I know, nor in POSIX '88 or later, nor XPG3 or later. K&R's `The C Programming Language' doesn't mention it, nor does Stevens's APUE. The GnomeICU author is reasonable and appreciates bug fixes. > Although I'd > just take out #else #include personally. And just leave the HAVE_STDLIB_H? That seems silly. Cheers, -- Jacques A. Vidrine http://www.nectar.cc/ NTT/Verio SME . FreeBSD UNIX . Heimdal Kerberos jvidrine@verio.net . nectar@FreeBSD.org . nectar@kth.se To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message