From owner-freebsd-virtualization@freebsd.org Thu Apr 8 00:38:39 2021 Return-Path: Delivered-To: freebsd-virtualization@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id F1E0C5C916D for ; Thu, 8 Apr 2021 00:38:39 +0000 (UTC) (envelope-from SRS0=OThS=JF=freebsd.org=grehan@iredmail.onthenet.com.au) Received: from vito-vars.onthenet.com.au (vito-vars.OntheNet.com.au [203.13.68.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4FG2SG6218z3Htx for ; Thu, 8 Apr 2021 00:38:38 +0000 (UTC) (envelope-from SRS0=OThS=JF=freebsd.org=grehan@iredmail.onthenet.com.au) Received: from alto.onthenet.com.au (alto.OntheNet.com.au [203.13.68.12]) by vito-vars.onthenet.com.au (Postfix) with ESMTPS id 3621520B4BB2 for ; Thu, 8 Apr 2021 10:38:29 +1000 (AEST) Received: from iredmail.onthenet.com.au (iredmail.onthenet.com.au [203.13.68.150]) by alto.onthenet.com.au (Postfix) with ESMTPS id 1E94C209E421 for ; Thu, 8 Apr 2021 10:38:29 +1000 (AEST) Received: from iredmail.onthenet.com.au (iredmail.onthenet.com.au [127.0.0.1]) by iredmail.onthenet.com.au (Postfix) with ESMTP id 15E12213EB08 for ; Thu, 8 Apr 2021 10:38:29 +1000 (AEST) Received: from iredmail.onthenet.com.au ([127.0.0.1]) by iredmail.onthenet.com.au (iredmail.onthenet.com.au [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id R5BjBIuu8gQD for ; Thu, 8 Apr 2021 10:38:29 +1000 (AEST) Received: from MacBook-Air-4.local (unknown [120.29.48.160]) by iredmail.onthenet.com.au (Postfix) with ESMTPSA id E353E213EB00; Thu, 8 Apr 2021 10:38:28 +1000 (AEST) Subject: Re: bhyve: regression in virtio-9p option parsing To: Roman Bogorodskiy References: Cc: freebsd-virtualization@freebsd.org From: Peter Grehan Message-ID: Date: Thu, 8 Apr 2021 10:38:27 +1000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=BZdDLol2 c=1 sm=1 tr=0 a=A6CF0fG5TOl4vs6YHvqXgw==:117 a=3Ck/IrRnVhCx8hPbmLB4Dw==:17 a=N659UExz7-8A:10 a=3YhXtTcJ-WEA:10 a=3YLw0sGB6tBBMPxcxDoA:9 a=pILNOxqGKmIA:10 X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=B/4iLNlM c=1 sm=1 tr=0 a=mJOSnoNX3k71adV6TmU0eQ==:117 a=3Ck/IrRnVhCx8hPbmLB4Dw==:17 a=N659UExz7-8A:10 a=3YhXtTcJ-WEA:10 a=3YLw0sGB6tBBMPxcxDoA:9 a=pILNOxqGKmIA:10 X-Rspamd-Queue-Id: 4FG2SG6218z3Htx X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of SRS0=OThS=JF=freebsd.org=grehan@iredmail.onthenet.com.au has no SPF policy when checking 203.13.68.24) smtp.mailfrom=SRS0=OThS=JF=freebsd.org=grehan@iredmail.onthenet.com.au X-Spamd-Result: default: False [-1.80 / 15.00]; RCVD_TLS_LAST(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_FIVE(0.00)[6]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-virtualization@freebsd.org]; RBL_DBL_DONT_QUERY_IPS(0.00)[203.13.68.24:from]; AUTH_NA(1.00)[]; DMARC_NA(0.00)[freebsd.org]; SPAMHAUS_ZRD(0.00)[203.13.68.24:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_HAM_MEDIUM(-1.00)[-0.998]; R_SPF_NA(0.00)[no SPF record]; FORGED_SENDER(0.30)[grehan@freebsd.org,SRS0=OThS=JF=freebsd.org=grehan@iredmail.onthenet.com.au]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:9313, ipnet:203.13.68.0/23, country:AU]; FROM_NEQ_ENVFROM(0.00)[grehan@freebsd.org,SRS0=OThS=JF=freebsd.org=grehan@iredmail.onthenet.com.au]; MAILMAN_DEST(0.00)[freebsd-virtualization] X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Apr 2021 00:38:40 -0000 Hi Roman, > diff --git a/usr.sbin/bhyve/pci_virtio_9p.c b/usr.sbin/bhyve/pci_virtio_9p.c > index e27159eb22cb..830e13878a71 100644 > --- a/usr.sbin/bhyve/pci_virtio_9p.c > +++ b/usr.sbin/bhyve/pci_virtio_9p.c > @@ -232,7 +232,7 @@ pci_vt9p_notify(void *vsc, struct vqueue_info *vq) > static int > pci_vt9p_legacy_config(nvlist_t *nvl, const char *opts) > { > - char *sharename, *tofree, *token, *tokens; > + char *sharename = NULL, *tofree, *token, *tokens; > > if (opts == NULL) > return (0); This looks fine to commit. later, Peter.