From owner-cvs-all@FreeBSD.ORG Fri Apr 21 15:15:18 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A6AF816A402; Fri, 21 Apr 2006 15:15:18 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id E324E43D48; Fri, 21 Apr 2006 15:15:17 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 0A9C946C6E; Fri, 21 Apr 2006 11:15:16 -0400 (EDT) Date: Fri, 21 Apr 2006 16:15:15 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Tom Rhodes In-Reply-To: <200604210714.k3L7EQhD046878@repoman.freebsd.org> Message-ID: <20060421161321.J44089@fledge.watson.org> References: <200604210714.k3L7EQhD046878@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/ufs/ffs ffs_vfsops.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Apr 2006 15:15:18 -0000 On Fri, 21 Apr 2006, Tom Rhodes wrote: > trhodes 2006-04-21 07:14:25 UTC > > FreeBSD src repository > > Modified files: > sys/ufs/ffs ffs_vfsops.c > Log: > Remove what I believe are two useless ifdefs. If a user or administrator > enables multilabel, or any option for that matter, most likely they have > a reason. This will allow users to see that mulilabel is enabled via an > issued "mount" command and remove an annoying warning - printed only when > a MAC kernel is not installed - on boot up. This seems incorrect to me. You have also removed the warnings associated with trying to use multi-label and ACL-enabled file systems on kernels not configured to support them, which can lead to highly undesirable behavior, hence the warnings. The mount point flags are intended to reflect the current mode of operation, and setting the flags when the operational mode isn't supported doesn't seem right. Robert N M Watson > > Discussed with: green, brueffer, Samy Al Bahra. > Probably ran past: csjp (though I can't remember). > > Revision Changes Path > 1.308 +0 -12 src/sys/ufs/ffs/ffs_vfsops.c >