From owner-freebsd-multimedia@FreeBSD.ORG Thu Apr 16 12:46:11 2009 Return-Path: Delivered-To: freebsd-multimedia@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 613D910657A0; Thu, 16 Apr 2009 12:46:11 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from redbull.bpaserver.net (redbullneu.bpaserver.net [213.198.78.217]) by mx1.freebsd.org (Postfix) with ESMTP id 08CF18FC26; Thu, 16 Apr 2009 12:46:10 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from outgoing.leidinger.net (pD9E2D0BE.dip.t-dialin.net [217.226.208.190]) by redbull.bpaserver.net (Postfix) with ESMTP id 11C892E0BA; Thu, 16 Apr 2009 14:30:11 +0200 (CEST) Received: from webmail.leidinger.net (webmail.leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id EC645B2522; Thu, 16 Apr 2009 14:30:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=Leidinger.net; s=outgoing-alex; t=1239885007; bh=dNg7pIGQPT1WewHOUC+eKxIUgQqZ5+LGX pBuYpehI2A=; h=Message-ID:Date:From:To:Cc:Subject:References: In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=pCR61Gzl1VmZ1pJrBnFrtfAcdhnoaPsLm1BODZsdjCmcH0/HZW2/7Qrd2CcZcOWl6 0JJ/5JALtyNZg+ZNWo7BuZFSs9iQv6+oUiPcm0kGSUxdZ652hRb0+ZrZKg/0cBnNHE7 mZIvkIvKE3JXO11rIbbk0lJuBL7qXHr/8k4xe1ugfgGl7+fy8eVGHWZS1mjm5skwQmJ 3DwfBk5KTkq1CJtWuxlJbNzm661iKP8oUUWJjd1RHJ4QcdTFQPDzTLq/2BmOyLqIoFK BgA7cf9xerSogMAxPbFwLNnCUPPr9d8maV+84fzUSgs5dToUo3a3+Uo7THxDBpevPXy q2tC3TRLw== Received: (from www@localhost) by webmail.leidinger.net (8.14.3/8.13.8/Submit) id n3GCU5Ok014247; Thu, 16 Apr 2009 14:30:05 +0200 (CEST) (envelope-from Alexander@Leidinger.net) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde Framework) with HTTP; Thu, 16 Apr 2009 14:30:05 +0200 Message-ID: <20090416143005.74393on2jzdlbts0@webmail.leidinger.net> X-Priority: 3 (Normal) Date: Thu, 16 Apr 2009 14:30:05 +0200 From: Alexander Leidinger To: Andriy Gapon References: <49E62215.4010309@icyb.net.ua> In-Reply-To: <49E62215.4010309@icyb.net.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable User-Agent: Internet Messaging Program (IMP) H3 (4.3) / FreeBSD-8.0 X-BPAnet-MailScanner-Information: Please contact the ISP for more information X-MailScanner-ID: 11C892E0BA.C5060 X-BPAnet-MailScanner: Found to be clean X-BPAnet-MailScanner-SpamCheck: not spam, ORDB-RBL, SpamAssassin (not cached, score=-13.504, required 6, BAYES_00 -15.00, DKIM_SIGNED 0.00, DKIM_VERIFIED -0.00, MIME_QP_LONG_LINE 1.40, RDNS_DYNAMIC 0.10) X-BPAnet-MailScanner-From: alexander@leidinger.net X-Spam-Status: No Cc: freebsd-multimedia@FreeBSD.org, Rui, Paulo , "M. Warner Losh" , John Baldwin Subject: Re: strict signatures for kobj methods in sound subsystem X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Apr 2009 12:46:13 -0000 Quoting Andriy Gapon (from Wed, 15 Apr 2009 21:06:13 +0300= ): > > Please review the attached, largely mechanical, patch for sound subsystem. > This patch is supposed to make all functions that implement kobj methods h= ave > strictly the same signatures as defined by the interfaces. As you have to change a lot of places, a question would be if it is ok =20 to change the interface from u_int32_t to int instead. I haven't =20 investigated if this is about our internal in-kernel interface, or =20 (indirectly) the official userland OSS interface. I also hadn't a look =20 what 3rd party sound drivers (e.g. in ports) are using. You are also mixing u_int32_t and uint32_t in the change. Most of them =20 are of the u_int32_t style, but some changes have uint32_t. Bye, Alexander. --=20 Bigamy is having one spouse too many. Monogamy is the same. http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID =3D B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID =3D 72077137