From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Apr 4 01:10:02 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 393801065676 for ; Sat, 4 Apr 2009 01:10:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 123F38FC13 for ; Sat, 4 Apr 2009 01:10:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n341A1kI042683 for ; Sat, 4 Apr 2009 01:10:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n341A1tM042682; Sat, 4 Apr 2009 01:10:01 GMT (envelope-from gnats) Resent-Date: Sat, 4 Apr 2009 01:10:01 GMT Resent-Message-Id: <200904040110.n341A1tM042682@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dmitry Marakasov Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C477110656C4 for ; Sat, 4 Apr 2009 01:00:57 +0000 (UTC) (envelope-from amdmi3@amdmi3.ru) Received: from smtp.timeweb.ru (smtp.timeweb.ru [217.170.79.85]) by mx1.freebsd.org (Postfix) with ESMTP id 511DA8FC19 for ; Sat, 4 Apr 2009 01:00:57 +0000 (UTC) (envelope-from amdmi3@amdmi3.ru) Received: from [213.148.20.85] (helo=hive.panopticon) by smtp.timeweb.ru with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.69) (envelope-from ) id 1LpuFk-0001Nh-Pa; Sat, 04 Apr 2009 05:00:56 +0400 Received: from hades.panopticon (hades.panopticon [192.168.0.32]) by hive.panopticon (Postfix) with ESMTP id A6FB2131FB; Sat, 4 Apr 2009 05:01:02 +0400 (MSD) Received: by hades.panopticon (Postfix, from userid 1000) id C8EA910883C; Sat, 4 Apr 2009 05:00:47 +0400 (MSD) Message-Id: <20090404010047.C8EA910883C@hades.panopticon> Date: Sat, 4 Apr 2009 05:00:47 +0400 (MSD) From: Dmitry Marakasov To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: erik@smluc.org Subject: ports/133354: [PATCH] audio/openal: fix segfault in some cases X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Apr 2009 01:10:03 -0000 >Number: 133354 >Category: ports >Synopsis: [PATCH] audio/openal: fix segfault in some cases >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sat Apr 04 01:10:01 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Dmitry Marakasov >Release: FreeBSD 8.0-CURRENT i386 >Organization: >Environment: System: FreeBSD hades.panopticon 8.0-CURRENT FreeBSD 8.0-CURRENT #0: Sat Mar 21 18:50:30 MSK 2009 >Description: When _alFloatMul is called on a very small buffer consisting of <= 2 samples, buffer length will be calculated incorrectly (512MB), which will lead to segfault. The patch fixes this and also improves performance a tiny bit (when buffer is aligned, first 4 samples will now be processed with mmx as they should). Added file(s): - files/patch-src-arch-i386-x86_floatmul.c Port maintainer (erik@smluc.org) is cc'd. Generated with FreeBSD Port Tools 0.77 >How-To-Repeat: >Fix: --- openal-20060211_9.patch begins here --- Index: Makefile =================================================================== RCS file: /home/amdmi3/projects/freebsd/FreeBSD.cvs/ports/audio/openal/Makefile,v retrieving revision 1.51 diff -u -u -r1.51 Makefile --- Makefile 17 Mar 2009 00:32:41 -0000 1.51 +++ Makefile 4 Apr 2009 00:55:08 -0000 @@ -7,7 +7,7 @@ PORTNAME= openal PORTVERSION= 20060211 -PORTREVISION= 8 +PORTREVISION= 9 CATEGORIES= audio MASTER_SITES= http://openal.org/openal_webstf/downloads/ DISTVERSION= 0.0.8 Index: files/patch-src-arch-i386-x86_floatmul.c =================================================================== RCS file: files/patch-src-arch-i386-x86_floatmul.c diff -N files/patch-src-arch-i386-x86_floatmul.c --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ files/patch-src-arch-i386-x86_floatmul.c 4 Apr 2009 00:53:56 -0000 @@ -0,0 +1,11 @@ +--- src/arch/i386/x86_floatmul.c.orig 2005-12-21 22:06:35.000000000 +0300 ++++ src/arch/i386/x86_floatmul.c 2009-04-04 04:53:56.000000000 +0400 +@@ -46,7 +46,7 @@ + v4hi temp; + + +- samples_pre = MMX_ALIGN - (aint)bpt % MMX_ALIGN; ++ samples_pre = (MMX_ALIGN - (aint)bpt % MMX_ALIGN) % MMX_ALIGN; + samples_pre /= sizeof(ALshort); + samples_main = len - samples_pre; + samples_post = samples_main % 8; --- openal-20060211_9.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: