From owner-svn-src-all@freebsd.org Thu Jan 24 20:08:48 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5915914BC95C; Thu, 24 Jan 2019 20:08:48 +0000 (UTC) (envelope-from gonzo@freebsd.org) Received: from id.bluezbox.com (id.bluezbox.com [45.55.20.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EB2648475A; Thu, 24 Jan 2019 20:08:47 +0000 (UTC) (envelope-from gonzo@freebsd.org) Received: from localhost ([127.0.0.1] helo=id.bluezbox.com) by id.bluezbox.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1 (FreeBSD)) (envelope-from ) id 1gmlIk-000P68-E3; Thu, 24 Jan 2019 12:08:39 -0800 Received: (from gonzo@localhost) by id.bluezbox.com (8.15.2/8.15.2/Submit) id x0OK8bMg096479; Thu, 24 Jan 2019 12:08:37 -0800 (PST) (envelope-from gonzo@freebsd.org) X-Authentication-Warning: id.bluezbox.com: gonzo set sender to gonzo@freebsd.org using -f Date: Thu, 24 Jan 2019 12:08:37 -0800 From: Oleksandr Tymoshenko To: rgrimes@freebsd.org Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r343391 - head/tools/tools/tinybsd Message-ID: <20190124200837.GA96390@bluezbox.com> References: <201901240634.x0O6YUIe013808@repo.freebsd.org> <201901241702.x0OH2GdN084159@pdx.rh.CN85.dnsmgr.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201901241702.x0OH2GdN084159@pdx.rh.CN85.dnsmgr.net> X-Operating-System: FreeBSD/11.1-RELEASE-p4 (amd64) User-Agent: Mutt/1.10.0 (2018-05-17) X-Spam-Level: -- X-Spam-Report: Spam detection software, running on the system "id.bluezbox.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see The administrator of that system for details. Content preview: Rodney W. Grimes (freebsd@pdx.rh.CN85.dnsmgr.net) wrote: > > Author: gonzo > > Date: Thu Jan 24 06:34:29 2019 > > New Revision: 343391 > > URL: https://svnweb.freebsd.org/changeset/base/343391 > > > > [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Rspamd-Queue-Id: EB2648475A X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.97)[-0.973,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jan 2019 20:08:48 -0000 Rodney W. Grimes (freebsd@pdx.rh.CN85.dnsmgr.net) wrote: > > Author: gonzo > > Date: Thu Jan 24 06:34:29 2019 > > New Revision: 343391 > > URL: https://svnweb.freebsd.org/changeset/base/343391 > > > > Log: > > Fix prompt for MFSROOT in tinybsd > > > > tinybsd offers two choices when prompting user for MFSROOT: 'YES' > > and 'NO'. Script logic only handles 'yes'. Change offered values > > to lower case. > > Why not fix this so that [Yy][Ee][Ss] is accepted? I thought about it but actual end-to-end verification of such fix would require going through whole build (and learning how tinybsd script works). It's a bit more effort than I would like to spend on the tool I don't work with and with the number of users I don't know of. The committed patch was readily available, easily verifiable and a step forward, a tiny one but nevertheless. If anybody wants to implement proper fix - feel free to reopen PR and take over it. -- gonzo