From owner-svn-src-head@freebsd.org Sun Jul 8 15:58:37 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6BB361033719 for ; Sun, 8 Jul 2018 15:58:37 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x236.google.com (mail-io0-x236.google.com [IPv6:2607:f8b0:4001:c06::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EEC957B2EF for ; Sun, 8 Jul 2018 15:58:36 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x236.google.com with SMTP id q4-v6so14953463iob.2 for ; Sun, 08 Jul 2018 08:58:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=qZHvpyhsNLpGyuhzQ98YV1d4CrnoAm14lNJgZCznvAg=; b=JXAZqI2agqWquUV2d0+Dg1dRQH1TKlcqLVDOShr/e82XiWDZrFGO7bQG/zgfm/PwXP eoYBpprPRfNrSCtuV+Z7HC0CCd7WHimfjOijYHbwIUcEJpqmtlNcU2MXwmhjG4Tfu3sP EMKbsXUrM5BnKlzAdX8NbgupmewWbCDHaF9DagsEt4N+ZtyX5BGqvjNIUSILt/3mEBF6 C8TJuUIbWy3zYwQ6h2ktRExlrfmZ2YO2i7Y6xYEt40WRCodL/oTNbTkXTSSTnoUpvbam SSPc/kfOofH80NW34124u4YfHujcDl2ZtEG6UC71K20Fv9nTmUol2qmRFWXGP0L13XzD Da9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=qZHvpyhsNLpGyuhzQ98YV1d4CrnoAm14lNJgZCznvAg=; b=kRoTIUD/beCxxdt27GorZx4Uof7I1OSO3ytM2wHm5mu9HFrKOAZN70ev5XKhuM3Zkt cFsncv3ljltOy/0kR3ZD7HpCiBfSP9cy+u/w+5+343cZ+fM77eIcqu2oKKPLPg4lMsOs GBkOa2hUl3zdQ9zpuxmOwG/pjOsWXuk1n1pVpsGeYZTF9a4EeIZbaSEJKeCFro1q1DFB SskSYUKu9Fca8JZyyH7ad4Ms+1jJKlikbCMreB/k3BRk5nwWI7M9jfEcYEwjqOqll2Aa q6e2V0uuv9RaUQD0hiCthianV16VHg/ywQs3clUmEwFM0GHnsKckzPj6E38/2aGA9xIl 0qJA== X-Gm-Message-State: APt69E0umiSPHi2cEgGADEjMuivyd9YobiEur/CgztUT/pQk5AtE9sed XJ6VTi5tWiSqgEq8V8Z37/KX3u4lKVw1M5HuskjLvQ== X-Google-Smtp-Source: AAOMgpfEJWhNeMLcwI/JcAtqqYkWiWZoOIMEXBvvIQ7odTqgYMHukUm6loY72WF2Rak92H6O93bmJwQ8v8c5jKB/fHI= X-Received: by 2002:a6b:d40c:: with SMTP id l12-v6mr14827251iog.37.1531065516007; Sun, 08 Jul 2018 08:58:36 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 2002:a4f:1183:0:0:0:0:0 with HTTP; Sun, 8 Jul 2018 08:58:35 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: <5483bcd6-f3bc-8b78-ee51-3bf3c2a1c2da@freebsd.org> References: <201806091447.w59ElnpU026396@repo.freebsd.org> <20180707174351.GA95934@pesky> <20180708152621.GB18193@pesky> <5483bcd6-f3bc-8b78-ee51-3bf3c2a1c2da@freebsd.org> From: Warner Losh Date: Sun, 8 Jul 2018 09:58:35 -0600 X-Google-Sender-Auth: oMQu8iYXZNmWF3bmeormSKAQs7c Message-ID: Subject: Re: svn commit: r334880 - head/sys/dev/vnic To: Sean Bruno Cc: Mark Johnston , Andrew Turner , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Jul 2018 15:58:37 -0000 On Sun, Jul 8, 2018 at 9:55 AM, Sean Bruno wrote: > > > On 07/08/18 09:26, Mark Johnston wrote: > > On Sun, Jul 08, 2018 at 09:10:27AM -0600, Sean Bruno wrote: > >> > >> > >> On 07/07/18 11:43, Mark Johnston wrote: > >>> On Sat, Jun 09, 2018 at 02:47:49PM +0000, Andrew Turner wrote: > >>>> Author: andrew > >>>> Date: Sat Jun 9 14:47:49 2018 > >>>> New Revision: 334880 > >>>> URL: https://svnweb.freebsd.org/changeset/base/334880 > >>>> > >>>> Log: > >>>> In the ThunderX BGX network driver we were skipping the NULL > terminator > >>>> when parsing the phy type, however this is included in the length > returned > >>>> by OF_getprop. To fix this stop ignoring the terminator. > >>>> > >>>> PR: 228828 > >>>> Reported by: sbruno > >>>> Sponsored by: DARPA, AFRL > >>> > >>> This seems to break vnic on packet.net ThunderXs. In particular, VF > >>> creation fails. It seems the problem in my case is that there are > >>> multiple PHY devices in the device tree, e.g., xfi@0, xfi@1. With > this > >>> change, bgx_fdt_phy_name_match() fails to match against any device > >>> containing a unit address in the node name. > >>> > >> > >> > >> Huh ... this was *required* to get the ThunderXs we have in the FreeBSD > >> cluster to work at all. o.0 > >> > >> I guess "someone" needs to contact "someone" to figure out which is > >> correct or we need to replace our FreeBSD cluster machines with ones > >> that work like the packet.net machines? > > > > I think the current code works fine if there's only one PHY device, so > > my problem is probably just the result of having a different hardware > > setup. We can probably fix the code to handle both cases. Could you > > mail me the output of "ofwdump -ap" from the cluster machine? > > > > > > > I dropped the output here: > https://people.freebsd.org/~sbruno/ofwdump.txt Ian's method is better. But Ian's question is better: are there not phandles to find this stuff? Names in FDT are kinda meaningless most of the time (I say kinda here to gloss over a laundry list of exceptions that PHY finding typically does not fall into). Warner