From owner-svn-src-all@freebsd.org Thu Jun 11 16:16:44 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 470883387ED for ; Thu, 11 Jun 2020 16:16:44 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound5a.ore.mailhop.org (outbound5a.ore.mailhop.org [44.233.67.66]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 49jTWb634Fz413p for ; Thu, 11 Jun 2020 16:16:43 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1591892196; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=jwqRKOy03dAU2qwLHUyih5F0wEmj+3OgigBtMlnnGcPfcUN6xGtOZegv2TQVJBxxRyvLPzcdOzray lR4/MuYgiVuJhy+HgYAo+VF0guHf3MvjXKHlJbOyXNKMfWzxZESvE5RnSelznzNLp2qMjt/8V0ir9G a7WnfHlbdzv5HTSlx0K5XQEYTvIPe+70+gFvJrBaIg/ahRLGE+Xvy5aaBZbrfG6VnifDEvvQB/2ydt QGzSzHrdBOWYGY5+/4l8sfiYuFxzEQzv8wXRycjhbIJLTSripbnMlOQzyGBwewGYExX458ojIXAD+a ZJVWpRyt/ZJv2jpMuZkmmVwHLiMyBhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=YYMGYo4fTX9lePPC/AVECpDVlRBfIPZ6jNFMBhnK5JA=; b=o8g7GQUItzN2NXHrcTAuHLpbpGMLbYQPQp9sJv3r+dNpdCSX6i03GWnJfZRuAQxWNo+A2NKc0hLKq HezGTSdb3gNQ5bxDiJpeEarF+z+XXCXdUOeSlMv3+qn4S8SbgAjnwNVFdfFv1avePl6w2G7dG3J0Pk bnxRNPhjf18SOTgrFetN9lo2crQgHhMGInOQhizM6+onhfeC4swLx+1II2hdiI2397AmkEQQ7W90UN rEcgD6Z75KSW/3bNUcFZyhfNl8nj8e8uFIPm3zqJZqltE53Y3MGqkH9P6fhYm4jXvCWBwsUTu/hUlH egaIlrjM5umcdNiJ93LY7t+2+2ygQ6Q== ARC-Authentication-Results: i=1; outbound3.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=YYMGYo4fTX9lePPC/AVECpDVlRBfIPZ6jNFMBhnK5JA=; b=u7ftqaKlRkpEAHS6rL87ecAKPuGLH0eZS4oZMi4Cu5txwc3YwKWiKdk/vVFkcH0ZMQ9s3ht+Hv4UQ B8lxSoKbPsL5S1ZXGN3WZTwkoVL3Bj1GEoeYNDwyCJRGdRS+7GO4OBXMgFEYS1IXvlCuGtx7VJ0lxj aVGTgivWxLefgXFJwQevXr3EnZ1tpv4lV7m33CqI/eszfqkRjc5BIQo8G0bjb/NdOe6yr5d/Fv1ZHF 2U2ohPWJFbwgE7q95fuW7YW8qktRiVAnvuj+f4s1LHiyCX66s6PcPqMyUfHw88b8GL2vwWyRE2Q3mK HXQyYoqYFZSMB21e9TwDHbYU//pKtYw== X-MHO-RoutePath: aGlwcGll X-MHO-User: ea37d850-abfe-11ea-b10c-b5956a7dd1a1 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (c-67-177-211-60.hsd1.co.comcast.net [67.177.211.60]) by outbound3.ore.mailhop.org (Halon) with ESMTPSA id ea37d850-abfe-11ea-b10c-b5956a7dd1a1; Thu, 11 Jun 2020 16:16:35 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id 05BGGWcV004738; Thu, 11 Jun 2020 10:16:32 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: Subject: Re: svn commit: r362017 - in head/usr.bin/sed: . tests From: Ian Lepore To: Steffen Nurpmeso , Mateusz Piotrowski <0mp@FreeBSD.org> Cc: Yuri Pankov , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Thu, 11 Jun 2020 10:16:32 -0600 In-Reply-To: <20200611142908.z3_Ao%steffen@sdaoden.eu> References: <202006101923.05AJNwPt006602@repo.freebsd.org> <20200610220619.Iup5c%steffen@sdaoden.eu> <995726df-cb28-c294-09ca-6cca302b24a6@FreeBSD.org> <20200611142908.z3_Ao%steffen@sdaoden.eu> Content-Type: text/plain; charset="ASCII" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 49jTWb634Fz413p X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [0.00 / 15.00]; local_wl_from(0.00)[freebsd.org]; ASN(0.00)[asn:16509, ipnet:44.224.0.0/11, country:US] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jun 2020 16:16:44 -0000 On Thu, 2020-06-11 at 16:29 +0200, Steffen Nurpmeso wrote: > Hello. > > Mateusz Piotrowski wrote in > <995726df-cb28-c294-09ca-6cca302b24a6@FreeBSD.org>: > |On 6/11/20 12:06 AM, Steffen Nurpmeso wrote: > |> Yuri Pankov wrote in > |> : > |>|Mateusz Piotrowski wrote: > |>|> Author: 0mp (doc,ports committer) > |>|> Date: Wed Jun 10 19:23:58 2020 > |>|> New Revision: 362017 > |>|> URL: https://svnweb.freebsd.org/changeset/base/362017 > |>|> > |>|> Log: > |>|> Read commands from stdin when -f - is passed to sed(1) > |> .. > |>|Am I reading it wrong, or is it the same test case added 3 times? > |> > |> It also used "Fl f Cm -" instead of "Fl f Ar -". Just saying.. > > |Which is correct. "-" is not a variable here. It is a fixed string hence > |the use of Cm. > > I would rather say no, .Ar is an argument (to the ".Fl"ag f), > whereas .Cm is a command modifier: > > Command Modifiers > The command modifier is identical to the '.Fl' (flag) command with the > exception that the '.Cm' macro does not assert a dash in front of every > argument. Traditionally flags are marked by the preceding dash, however, > some commands or subsets of commands do not use them. Command modifiers > may also be specified in conjunction with interactive commands such as > editor commands. > Yeah, but... The '.Fl' macro without any arguments results in a dash representing stdin/stdout. Note that giving '.Fl' a single dash will result in two dashes. The '.Fl' macro is parsed and is callable. And that seems to argue that "Fl f Fl" is correct. -- Ian