From owner-cvs-all@FreeBSD.ORG Fri Mar 31 09:29:50 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0933116A426 for ; Fri, 31 Mar 2006 09:29:50 +0000 (UTC) (envelope-from joao.barros@gmail.com) Received: from xproxy.gmail.com (xproxy.gmail.com [66.249.82.193]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2469343D55 for ; Fri, 31 Mar 2006 09:29:47 +0000 (GMT) (envelope-from joao.barros@gmail.com) Received: by xproxy.gmail.com with SMTP id s9so426223wxc for ; Fri, 31 Mar 2006 01:29:47 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=BXRY2OaEir2vi6E1FVeWy6/VHaEDpbIXrnWKSApbTva8WYzCoQjgXOVijVElNzttDYrkAd74VL06Nd2AY9ximgSZDG+CyLYKQUSMf0HLtGo5oDrdMaLWFtJJY4/k6zU29HDwfGWybZf8VrL2kkEynnrCUXVHQ/seGeCyNgjJ+gg= Received: by 10.70.17.2 with SMTP id 2mr240844wxq; Fri, 31 Mar 2006 01:29:47 -0800 (PST) Received: by 10.70.36.17 with HTTP; Fri, 31 Mar 2006 01:29:47 -0800 (PST) Message-ID: <70e8236f0603310129r5fe4e3a4qd9cb329c768860cc@mail.gmail.com> Date: Fri, 31 Mar 2006 10:29:47 +0100 From: "Joao Barros" To: "Robert Watson" In-Reply-To: <20060331090421.I9972@fledge.watson.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <200603302104.k2UL4qF7086165@repoman.freebsd.org> <20060331080654.GB776@turion.vk2pj.dyndns.org> <20060331090421.I9972@fledge.watson.org> Cc: src-committers@freebsd.org, "Christian S.J. Peron" , cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/usr.sbin/syslogd syslogd.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Mar 2006 09:29:50 -0000 On 3/31/06, Robert Watson wrote: > > On Fri, 31 Mar 2006, Peter Jeremy wrote: > > > On Thu, 2006-Mar-30 21:04:52 +0000, Christian S.J. Peron wrote: > >> This change allows syslogd to ignore ENOSPC space errors, so that whe= n the > >> filesystem is cleaned up, syslogd will automatically start logging ag= ain > >> without requiring the reset. This makes syslogd(8) a bit more reliabl= e. > > > > My sole concern with this is that this means that syslogd will keep try= ing > > to write to the full filesystem - and the kernel will log the attempts = to > > write to a full filesystem. Whilst there's rate limiting in the kernel= , > > this sort of feedback loop is undesirable. > > What I'd like to see is an argument to syslogd to specify a maximum full = level > for the target file system. Log data is valuable, but being able to writ= e to > /var/tmp/vi.recover is also important. syslogd -l 90% could specify that > sylogd should not write log records, perhaps other than an "out of space > record" to a log file on a file system with >=3D90% capacity. This preve= nts the > kernel from spewing about being out of space also. The accounting code d= oes > exactly this, for identical reasons. > > Robert N M Watson I was in bed last night and thought about this but also remembered something: imagine a very busy syslog machine, won't this "free space check" be a burden? I have a syslog machine at work that can fill up 30GB of disk in less than 2 hours and it's busy as it is :-) The solution as you correctly point out is it being optional. Take in consideration that checking by percentage can be tricky. On a very large disk that's inefficient, on a small one dangerous. Maybe a choice between percentage and real space is best. Does the kernel automatically starts complaining about out of space at 90%? If so that undermines my previous suggestions, but the questions remain ;-) -- Joao Barros