From owner-svn-ports-all@FreeBSD.ORG Wed Apr 29 15:23:04 2015 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3C007D3B for ; Wed, 29 Apr 2015 15:23:04 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 05CE51D71 for ; Wed, 29 Apr 2015 15:23:04 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.9/8.14.9) with ESMTP id t3TFN3jL088144 for ; Wed, 29 Apr 2015 15:23:03 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.9/8.14.9/Submit) id t3TFN3Ut088136 for svn-ports-all@freebsd.org; Wed, 29 Apr 2015 15:23:03 GMT (envelope-from bdrewery) Received: (qmail 55249 invoked from network); 29 Apr 2015 10:23:01 -0500 Received: from unknown (HELO ?10.10.1.139?) (freebsd@shatow.net@10.10.1.139) by sweb.xzibition.com with ESMTPA; 29 Apr 2015 10:23:01 -0500 Message-ID: <5540F758.2030605@FreeBSD.org> Date: Wed, 29 Apr 2015 10:23:04 -0500 From: Bryan Drewery Organization: FreeBSD User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Jan Beich CC: Lars Engels , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@FreeBSD.ORG, shadowbq@gmail.com Subject: Re: svn commit: r384872 - in head/security: . passivedns passivedns/files References: <201504272033.t3RKXcGl079169@svn.freebsd.org> <553FD751.6060408@FreeBSD.org> In-Reply-To: OpenPGP: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="P6oNouVf0tRrgJuoKgaTwKEhnb7mMBCAl" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Apr 2015 15:23:04 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --P6oNouVf0tRrgJuoKgaTwKEhnb7mMBCAl Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 4/28/2015 2:30 PM, Jan Beich wrote: > Bryan Drewery writes: >=20 >> On 4/27/2015 3:33 PM, Lars Engels wrote: >> >>> +DISTVERSION=3D ${GH_TAG} >> [...] >>> +GH_TAG=3D a6c7e26 >> >> Actually this is not valid either. As soon as a new commit is done the= >> port may "go backwards". >=20 >> Commit hashses are not valid versions. Dates are. >=20 > git describe --tags output is no worse than appending svn revision to > the nearest tag. DISTFILES was already partially correct. >=20 > $ pkg version -t 1.1.3 1.1.3-60 > < >=20 >> A PORTEPOCH bump will be needed as well after fixing this. >=20 > Not really. bsd.port.mk assumes any letter as a pre-release suffix. >=20 > # PORTVERSION=3Da6c7e26 > $ pkg version -t a6c7e26 0 > < >=20 > # DISTVERSION=3Da6c7e26 > $ pkg version -t a6.c7.e26 0 > < No. The next hash could start with 'f' and the one after 'a'. Git hashes are not monotonically increasing. --=20 Regards, Bryan Drewery --P6oNouVf0tRrgJuoKgaTwKEhnb7mMBCAl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJVQPdYAAoJEDXXcbtuRpfPo6gIAIcx5xuztynFj6MFJPbd0VCP grEnUx5op82MIdw18ILATaeNlZlr/sBI7oE04eh0QrJWtLs3iJSs3FPAVZY/j6Uk meHZzQIGBFcHM6jdbtJ+mR5Z/KvxeeAvAyql0eblHaaw0LmYlsbzxsdp9sS6ny9R I4blL2EWN2MuR65TkRUP+xWkLVibrLNeWkTwbNGWmNeLgE9PD/HNBJAM+ptRsAsu epd1P5+oPD5tA5wtJVJMKCj3DJVVqVc2Xi/Hlbovzq6YzSAJ3mOu2p0eRn7C9ZmU IHyQWfuS+T/ZDlL0r1kRsxIwdXMrRfD2YpYx8EjMhaDwFnec7lz61XELc+2N4gg= =a3ah -----END PGP SIGNATURE----- --P6oNouVf0tRrgJuoKgaTwKEhnb7mMBCAl--