From owner-freebsd-current Fri Oct 4 17:30:24 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9C76137B401 for ; Fri, 4 Oct 2002 17:30:22 -0700 (PDT) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6958743E42 for ; Fri, 4 Oct 2002 17:30:20 -0700 (PDT) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (fledge.pr.watson.org [192.0.2.3]) by fledge.watson.org (8.12.4/8.12.4) with SMTP id g950TpOo075137; Fri, 4 Oct 2002 20:29:52 -0400 (EDT) (envelope-from robert@fledge.watson.org) Date: Fri, 4 Oct 2002 20:29:51 -0400 (EDT) From: Robert Watson X-Sender: robert@fledge.watson.org To: "Greg 'groggy' Lehey" Cc: Terry Lambert , Emiel Kollof , Peter Wemm , Poul-Henning Kamp , n0go013 , current Subject: Re: [ GEOM tests ] disklabel warnings and vinum drives lost In-Reply-To: <20021005002350.GR72541@wantadilla.lemis.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat, 5 Oct 2002, Greg 'groggy' Lehey wrote: > FWIW, I've never seen this code. The dates on the patch suggest that > it was made in the last quarter of an hour: I didn't claim that this was his code. This was code I just wrote to address Vinum not finding the devices due to major/minor number changes. I was referring to a separate problem involving a zero'd sectorsize resulting in a divide by zero in the kernel, which Jeff reported experiencing and fixing previously. > > --- vinumio.c 21 Aug 2002 23:39:51 -0000 1.75 > > +++ vinumio.c 5 Oct 2002 00:03:09 -0000 > > However: > > RCS file: /home/ncvs/src/sys/modules/vinum/Makefile,v > revision 1.18 > date: 2000/04/16 00:17:46; author: grog; state: Exp; lines: +1 -3 > Remove MAINTAINER. > > Since that point, this particular file has had 5 updates, only one from > me. Jeff's a committer; he can commit it himself if he wants. Hmm. Funny, I was paying more attention to the line in the MAINTAINER's file which seems to suggest you are the maintainer. :-) Given that you appear to have read this patch -- may I commit it since it appears to resolve the first of the nits I ran into using Vinum with GEOM? There appear to be more problems in the tubes, but this one seemed straight-forward enough, especially since the functionality this patch replaces seems not to be in the tree. Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Network Associates Laboratories To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message