From owner-freebsd-ports@FreeBSD.ORG  Wed Jul 30 12:14:38 2008
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7956E1065672
	for <freebsd-ports@freebsd.org>; Wed, 30 Jul 2008 12:14:38 +0000 (UTC)
	(envelope-from kris@FreeBSD.org)
Received: from weak.local (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 933598FC18;
	Wed, 30 Jul 2008 12:14:37 +0000 (UTC)
	(envelope-from kris@FreeBSD.org)
Message-ID: <48905B2B.6060804@FreeBSD.org>
Date: Wed, 30 Jul 2008 14:14:35 +0200
From: Kris Kennaway <kris@FreeBSD.org>
User-Agent: Thunderbird 2.0.0.16 (Macintosh/20080707)
MIME-Version: 1.0
To: Vladimir Chukharev <Vladimir.Chukharev@tut.fi>
References: <op.ueqfl1xy0g54sc@localhost> <08GlBzRclM@dmeyer.dinoex.sub.org>
	<op.ueumske80g54sc@localhost> <op.ueuwd8rs0g54sc@localhost>
	<488A0B2E.9070403@FreeBSD.org> <op.ue17xeex0g54sc@localhost>
	<op.ue3qhisl0g54sc@localhost> <48904BDC.1010706@FreeBSD.org>
	<op.ue3reildpcmiy5@localhost>
In-Reply-To: <op.ue3reildpcmiy5@localhost>
Content-Type: text/plain; charset=KOI8-R; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Dirk Meyer <dirk.meyer@dinoex.sub.org>, freebsd-ports@freebsd.org
Subject: Re: Mk/bsd.openssl.mk optimization
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Jul 2008 12:14:38 -0000

Vladimir Chukharev wrote:
> On Wed, 30 Jul 2008 14:09:16 +0300, Kris Kennaway <kris@freebsd.org> wrote:
> 
>> V.Chukharev wrote:
> 
>>> I have found why there is a difference in INDEX-7 generated with and without caching.
>>> Without cache security/p5-openxpki* (6 connected ports) are indexed as depending on
>>> both openssl-0.9.8h_1 and openssl-beta-0.9.8h_1 (beta is not actually installed),
>>> while with cache the second dependence is lost. This is due to WITH_OPENSSL_BETA
>>> defined in security/p5-openxpki/Makefile (master for other slave ports).
>>>
>>> So, Dirk, you are right, cashing breaks current behavior.
>> No, it means that you need to add extra checks to how the cached value
>> is used.
> 
> This is also true, but it might be spreaded over many ports and/or bsd.*.mk files...

No, I don't think so.  You need to make bsd.openssl.mk not use the 
cached value if it should not be, e.g. if WITH_OPENSSL_BETA is set.

>>> But now I wonder if the current behavior is correct and if security/p5-openxpki is
>>> correct. IMHO at least one of the two dependences is in err.
> 
> Can you comment on this?

Seems wrong to me.

Kris