From owner-svn-src-all@freebsd.org  Tue Oct 20 21:50:28 2015
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id B408CA1AC36;
 Tue, 20 Oct 2015 21:50:28 +0000 (UTC)
 (envelope-from carpeddiem@gmail.com)
Received: from mail-io0-x229.google.com (mail-io0-x229.google.com
 [IPv6:2607:f8b0:4001:c06::229])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 82C021F2E;
 Tue, 20 Oct 2015 21:50:28 +0000 (UTC)
 (envelope-from carpeddiem@gmail.com)
Received: by iofz202 with SMTP id z202so37756447iof.2;
 Tue, 20 Oct 2015 14:50:27 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:from:date:message-id
 :subject:to:cc:content-type;
 bh=+JmxL6D/eLT+QVpywnQQST48AE3GlyNJrGGwY7SVKfY=;
 b=F18ElgT2BK9+qnMWS1F8ZPysMo01H8yImiefmJ527olR/HAx9uhD1LfCnV3jyGqZKX
 E8Dk1biZScPZpV9SkwSG5RGw420fXGTggHAsA4Fx4Kah7wJ5Um0RQ4G8u9jcQc/QLZ+u
 7MAX/5CFmxEKVrg0HxMfRIrABlbkfW/zZqiMwyfM2NZbYhSliR0ZypMvhDPGw/dfBXwa
 OzV2a86n5Tya2V+03PSqjkHuG8uW/nuOWEpmu8lHE65T7Zw+YVBJV1Bo1P71XOAlSXDf
 ybbVEaKy8GUqciTt1FIQSswU3rvJyQv/iWzA8TK9T/4zydrAIoGHcpdVkjn7IY/GLCvY
 WTkg==
X-Received: by 10.107.165.140 with SMTP id o134mr6318892ioe.29.1445377827662; 
 Tue, 20 Oct 2015 14:50:27 -0700 (PDT)
MIME-Version: 1.0
Sender: carpeddiem@gmail.com
Received: by 10.107.158.75 with HTTP; Tue, 20 Oct 2015 14:50:08 -0700 (PDT)
In-Reply-To: <5626A748.5040101@FreeBSD.org>
References: <201510202038.t9KKcKW5064373@repo.freebsd.org>
 <5626A748.5040101@FreeBSD.org>
From: Ed Maste <emaste@freebsd.org>
Date: Tue, 20 Oct 2015 17:50:08 -0400
X-Google-Sender-Auth: z5XE5vyoMLsmemZMFhQeJagMHTk
Message-ID: <CAPyFy2AwSbP6uVLN5eCuZqqRsDXPfcw7q63nj9rStqVsuhXMtw@mail.gmail.com>
Subject: Re: svn commit: r289664 - head/sys/kern
To: Bryan Drewery <bdrewery@freebsd.org>
Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, 
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, 
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Content-Type: text/plain; charset=UTF-8
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Oct 2015 21:50:28 -0000

On 20 October 2015 at 16:42, Bryan Drewery <bdrewery@freebsd.org> wrote:
>
> I really think we should just do a full revert and recommit in these
> cases, and not even a forced commit.  Neither this commit or a forced
> commit will show in 'svn blame' or even during a bisect.  It really just
> becomes luck to find the right commit noting the message.  IMHO 'svn
> blame' is more important than some extra churn in 'svn log' or email. It
> does add more steps in 'svn blame' but it ends up giving the right
> message more obviously.
>
> I'm not asking to redo this commit now, but I think we should have a
> standard of just recommitting to fix mistakes.

This is the approach taken by LLVM and it works well there. You're
right that it introduces a bit of churn but I think it's worth the
cost.