From owner-svn-src-all@FreeBSD.ORG Fri Nov 6 18:28:32 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7193C10656C0; Fri, 6 Nov 2009 18:28:32 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 42FA28FC14; Fri, 6 Nov 2009 18:28:32 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id E8F5946B46; Fri, 6 Nov 2009 13:28:31 -0500 (EST) Received: from jhbbsd.hudson-trading.com (unknown [209.249.190.8]) by bigwig.baldwin.cx (Postfix) with ESMTPA id 111938A01D; Fri, 6 Nov 2009 13:28:31 -0500 (EST) From: John Baldwin To: Gavin Atkinson Date: Fri, 6 Nov 2009 13:22:02 -0500 User-Agent: KMail/1.9.7 References: <200911061452.nA6Eqbxm020072@svn.freebsd.org> <1257525277.64262.5.camel@buffy.york.ac.uk> In-Reply-To: <1257525277.64262.5.camel@buffy.york.ac.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200911061322.02504.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Fri, 06 Nov 2009 13:28:31 -0500 (EST) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00,RDNS_NONE autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: svn-src-all@freebsd.org Subject: Re: svn commit: r198987 - in head/sys/dev: an ixgb vge X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Nov 2009 18:28:32 -0000 On Friday 06 November 2009 11:34:37 am Gavin Atkinson wrote: > On Fri, 2009-11-06 at 14:52 +0000, John Baldwin wrote: > > Author: jhb > > Date: Fri Nov 6 14:52:37 2009 > > New Revision: 198987 > > URL: http://svn.freebsd.org/changeset/base/198987 > > > > Log: > > Use device_printf() and if_printf() instead of printf() with an explicit > > unit number and remove 'unit' members from softc. > > > > Modified: > > head/sys/dev/an/if_an.c > [snip] > > This covers most, but not all of my PR 126924 - is there any chance you > could look at the rest of it? (I can create a new patch if you wish). Actually, I didn't touch if_an_pci.c, so I think the patch in the PR still applies. The PR patch looks good to me. I can commit it in a second. Do you still have the an(4) card? If so, would you be able to test the patch at http://www.FreeBSD.org/~jhb/patches/cleanup.patch? For an(4) specifically it fixes several issues in the locking as well as changing the watchdog handling to not use the deprecated if_watchdog interface. Thanks. -- John Baldwin