From owner-cvs-all@FreeBSD.ORG  Sun Jan  9 09:01:01 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 27A3116A4CE; Sun,  9 Jan 2005 09:01:01 +0000 (GMT)
Received: from pittgoth.com (14.zlnp1.xdsl.nauticom.net [209.195.149.111])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id A69D543D39; Sun,  9 Jan 2005 09:01:00 +0000 (GMT)
	(envelope-from trhodes@FreeBSD.org)
Received: from mobile.pittgoth.com (ip68-230-188-82.dc.dc.cox.net
	[68.230.188.82])	(authenticated bits=0)
	by pittgoth.com (8.12.10/8.12.10) with ESMTP id j0990xoa032107
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT);
	Sun, 9 Jan 2005 04:00:59 -0500 (EST)
	(envelope-from trhodes@FreeBSD.org)
Date: Sun, 9 Jan 2005 04:00:59 -0500
From: Tom Rhodes <trhodes@FreeBSD.org>
To: Colin Percival <colin.percival@wadham.ox.ac.uk>
Message-ID: <20050109040059.6e14a902@mobile.pittgoth.com>
In-Reply-To: <41E0D155.9020704@wadham.ox.ac.uk>
References: <200501082256.j08Mu9XJ015280@repoman.freebsd.org>
	<41E0D155.9020704@wadham.ox.ac.uk>
X-Mailer: Sylpheed-Claws 0.9.13 (GTK+ 1.2.10; i386-portbld-freebsd5.3)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sbin/ping6 Makefile ping6.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 09 Jan 2005 09:01:01 -0000

On Sat, 08 Jan 2005 22:38:13 -0800
Colin Percival <colin.percival@wadham.ox.ac.uk> wrote:

> Tom Rhodes wrote:
> >   Modified files:
> >     sbin/ping6           Makefile ping6.c 
> >   Log:
> >   Use static const char and bump WARNS.
> 
> Judging by the latest tinderbox build, it looks like you
> need to replace "size_t" with "socklen_t" at line 1772 of
> ping6.c before setting WARNS=6.

But I only bumped it to two.

But with that change, I get this on my p4:

%make WARNS=6
Warning: Object directory not changed from original /usr/home/trhodes/work/curr
nt/src/sbin/ping6
cc -O -pipe -march=pentium4 -DINET6 -DIPSEC -DKAME_SCOPEID -DUSE_RFC2292BIS  -D
AVE_POLL_H -DHAVE_ARC4RANDOM -Wsystem-headers -Werror -Wall -Wno-format-y2k -W 
Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qu
l -Wwrite-strings -Wswitch -Wshadow -Wcast-align -Wchar-subscripts -Winline -Wn
sted-externs -Wredundant-decls -c ping6.c
ping6.c: In function `main':
ping6.c:398: warning: comparison between signed and unsigned
ping6.c:694: warning: comparison between signed and unsigned
ping6.c:726: warning: comparison between signed and unsigned
ping6.c: In function `dnsdecode':
ping6.c:1432: warning: comparison between signed and unsigned
ping6.c: In function `pr_pack':
ping6.c:1490: warning: comparison between signed and unsigned
ping6.c: At top level:
ping6.c:2172: warning: unused parameter 'notused'
ping6.c: In function `pr_retip':
ping6.c:2525: warning: comparison between signed and unsigned
ping6.c: In function `fill':
ping6.c:2619: warning: comparison between signed and unsigned
ping6.c: At top level:
ping6.c:2635: warning: unused parameter 'so'
*** Error code 1

Stop in /usr/home/trhodes/work/current/src/sbin/ping6.

Looks like just that change doesn't make it WARNS=6 clean.  :)

-- 
Tom Rhodes