From nobody Thu Mar 2 14:12:00 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PSChw5cvMz3vryp; Thu, 2 Mar 2023 14:12:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PSChw55PDz4GGW; Thu, 2 Mar 2023 14:12:00 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1677766320; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xJxJ6u43zHN4N8BqxTJEFByewr/AOVg+cFdWsyfkvjM=; b=wD9SAMQffYvk+pAyATyklNq/J+OPBrPUFct2VrdOdvpUUFCbVO/ULBqseRMYT+mB6bBXXs zz46TabC9KZRB9KPZZJ65Y3dA2amYe4HX50/qGH5rzqrCJvuFqxqDEQD0YJhDw5gC8Ifjj 9LVg1avdikE8NqtujGUrdndeX0l3f06EBlohDY3IURufghBylOz8cJ4p/Ovb2CkIMZhgB5 aprbNyYeeah0FKB9cBBJ96HVp+ZjZzq3gb6ltGoXz+Y4Ppmx91BmqLefBodGr4lE+QHUB8 Ph99XTg3E2u3Pwh93oRU3SkWtMYmmhrWYsvyiE3JNnVZ9/PrtCeBj4TtoPGumQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1677766320; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xJxJ6u43zHN4N8BqxTJEFByewr/AOVg+cFdWsyfkvjM=; b=gcX+MzJ6OuV/zS0wEfw9ubF0IQXT1BvLpA+ULOshs4wIh0bCzGcM5vCuUlUR2ND1ryVS2p 7F7vH8Q2z1haqMnrLBqX9nDdhSIKZ77VOlgEvgIFq+UHylvNao0NYAEQT+7C8qXdr24ECq i0cu8qKbRpoMhc1BUV+lHI1j0A+r7wAGcRdTHMgcPUtq1khLyNtxfEoL/fT9zpCWfz8yrq KhSgjmsvk6wtcKozpn/iZrwAeTjAjEkONNJ/+OrV+AlrmpeZmXAnOU6jMQnrEdBGtCd0AP gD+MawAkeBZZk3fBXhp3e+VVcjiYrqLDMZdz/hVajB9Bj7fWbHcHb7F6O7/b6g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1677766320; a=rsa-sha256; cv=none; b=i9nBkPE7DDQ1UIWq1iL0Lty2ThDCo7KmJjcy8j3+lA6r8hrV4ZZEPbakQjd+ehbDPJI1+t 35RiCXBkJR8ECiSyf/sUf22mK/uqOsKyED4n8jQet/V7JMv86u78Q7JR7VMXqLTi6yCw8A Few0L+p3ZYUg1rFasobH8FGWnXFu8Ky0N+XHt+iVu1K71W7C0MxEyx5KhrMFZaWmFqMLR2 854k9AmS7EpMLHBEs8SfmF+r6rGBQQMYsB08gCsvxI2pGjHWrWAwdsI5zWnotdYoOWwnff AUbcJU8c+nbetG2S2xIAmtJSMJGonjM+1a21jKDdQ6GGTlh/PGo9T8USEEWAwg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PSChw48TLzK97; Thu, 2 Mar 2023 14:12:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 322EC0lW037432; Thu, 2 Mar 2023 14:12:00 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 322EC04Z037431; Thu, 2 Mar 2023 14:12:00 GMT (envelope-from git) Date: Thu, 2 Mar 2023 14:12:00 GMT Message-Id: <202303021412.322EC04Z037431@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Ed Maste Subject: git: e8f143cc4c58 - stable/13 - Cirrus-CI: use makefs if root size exceeds QEMU's virtual FAT limit List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: e8f143cc4c5811a9ecbd3f2b1df02dd1ea2dfa94 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=e8f143cc4c5811a9ecbd3f2b1df02dd1ea2dfa94 commit e8f143cc4c5811a9ecbd3f2b1df02dd1ea2dfa94 Author: Ed Maste AuthorDate: 2023-02-13 17:39:39 +0000 Commit: Ed Maste CommitDate: 2023-03-02 14:11:53 +0000 Cirrus-CI: use makefs if root size exceeds QEMU's virtual FAT limit We use QEMU's virtual FAT support to avoid having to create a disk image because it is much faster, but it has a limit of about 500MB. Artifacts produced by the GCC 12 CI job exceeded this size. Add support for creating a FAT partition image and MBR-partitioned disk image and use it when the file system is too large for QEMU. In one run the Cirrus-CI LLVM test task took 1m33s using QEMU's virtual FAT while the GCC task took 6m48s using makefs+mkimg. Reviewed by: imp Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D38589 (cherry picked from commit 7b0593fdcbbb9c73d282fc0024d844c044423b31) --- tools/boot/ci-qemu-test.sh | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/tools/boot/ci-qemu-test.sh b/tools/boot/ci-qemu-test.sh index e6481c794af5..b730e9725014 100755 --- a/tools/boot/ci-qemu-test.sh +++ b/tools/boot/ci-qemu-test.sh @@ -21,7 +21,7 @@ die() tempdir_cleanup() { trap - EXIT SIGINT SIGHUP SIGTERM SIGQUIT - rm -rf ${ROOTDIR} + rm -rf ${WORKDIR} } tempdir_setup() @@ -99,18 +99,31 @@ arm64) esac # Create a temp dir to hold the boot image. -ROOTDIR=$(mktemp -d -t ci-qemu-test-fat-root) +WORKDIR=$(mktemp -d -t ci-qemu-test-fat-root) +ROOTDIR=${WORKDIR}/stage-root trap tempdir_cleanup EXIT SIGINT SIGHUP SIGTERM SIGQUIT # Populate the boot image in a temp dir. ( cd ${SRCTOP} && tempdir_setup ) +# Using QEMU's virtual FAT support is much faster than creating a disk image, +# but only supports about 500MB. Fall back to creating a disk image if the +# staged root is too large. +hda="fat:${ROOTDIR}" +rootsize=$(du -skA ${ROOTDIR} | sed 's/[[:space:]].*$//') +if [ $rootsize -gt 512000 ]; then + echo "Root size ${rootsize}K too large for QEMU virtual FAT" >&2 + makefs -t msdos -s 1g $WORKDIR/image.fat $ROOTDIR + mkimg -s mbr -p efi:=$WORKDIR/image.fat -o $WORKDIR/image.mbr + hda="$WORKDIR/image.mbr" +fi + # And, boot in QEMU. : ${BOOTLOG:=${TMPDIR:-/tmp}/ci-qemu-test-boot.log} timeout 300 \ $QEMU -m 256M -nodefaults \ -serial stdio -vga none -nographic -monitor none \ - -snapshot -hda fat:${ROOTDIR} 2>&1 | tee ${BOOTLOG} + -snapshot -hda $hda 2>&1 | tee ${BOOTLOG} # Check whether we succesfully booted... if grep -q 'Hello world.' ${BOOTLOG}; then