From owner-svn-src-all@FreeBSD.ORG  Sun Sep 15 07:48:43 2013
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 43B18433;
 Sun, 15 Sep 2013 07:48:43 +0000 (UTC)
 (envelope-from dumbbell@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org
 [IPv6:2001:1900:2254:2068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 2EEEF23F7;
 Sun, 15 Sep 2013 07:48:43 +0000 (UTC)
Received: from svn.freebsd.org ([127.0.1.70])
 by svn.freebsd.org (8.14.7/8.14.7) with ESMTP id r8F7mhKC019068;
 Sun, 15 Sep 2013 07:48:43 GMT
 (envelope-from dumbbell@svn.freebsd.org)
Received: (from dumbbell@localhost)
 by svn.freebsd.org (8.14.7/8.14.5/Submit) id r8F7mg6H019063;
 Sun, 15 Sep 2013 07:48:42 GMT
 (envelope-from dumbbell@svn.freebsd.org)
Message-Id: <201309150748.r8F7mg6H019063@svn.freebsd.org>
From: Jean-Sebastien Pedron <dumbbell@FreeBSD.org>
Date: Sun, 15 Sep 2013 07:48:42 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r255587 - head/sys/dev/drm2/radeon
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 15 Sep 2013 07:48:43 -0000

Author: dumbbell
Date: Sun Sep 15 07:48:42 2013
New Revision: 255587
URL: http://svnweb.freebsd.org/changeset/base/255587

Log:
  drm/radeon: Add missing "return false" after unmapping invalid BIOS
  
  Without that, we would try to copy the unmapped BIOS.
  
  Submitted by:	Christoph Mallon <christoph.mallon@gmx.de>
  Approved by:	re (blanket)

Modified:
  head/sys/dev/drm2/radeon/radeon_bios.c

Modified: head/sys/dev/drm2/radeon/radeon_bios.c
==============================================================================
--- head/sys/dev/drm2/radeon/radeon_bios.c	Sun Sep 15 01:44:07 2013	(r255586)
+++ head/sys/dev/drm2/radeon/radeon_bios.c	Sun Sep 15 07:48:42 2013	(r255587)
@@ -123,6 +123,7 @@ static bool radeon_read_bios(struct rade
 			    __func__, bios[0], bios[1]);
 		}
 		vga_pci_unmap_bios(vga_dev, bios);
+		return false;
 	}
 	rdev->bios = malloc(size, DRM_MEM_DRIVER, M_WAITOK);
 	memcpy(rdev->bios, bios, size);