Date: Tue, 21 Jul 2020 16:14:07 +0000 From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 238478] TCP Cubic code bug in cubic_ack_received Message-ID: <bug-238478-7501-YyaapubL8R@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-238478-7501@https.bugs.freebsd.org/bugzilla/> References: <bug-238478-7501@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D238478 --- Comment #4 from Richard Scheffenegger <rscheff@freebsd.org> --- Actually, concave and convex regions are defined with respect to the previo= us cwnd (max_cwnd in the code), not the currently used cwnd. The conditional in that space is there to prevent cwnd from shrinking, shou= ld it have outgrown the currently calculated w_cubic_next value (e.g. during slow-start). So, after a close inspection, showing the cwnd to follow both convex and concave trajectories properly, I believe the current code is correct. As th= ere are some style issues, and the comment could be expanded around this, will commit a patch against this PR nevertheless. --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-238478-7501-YyaapubL8R>