Date: Tue, 04 Nov 2014 16:38:09 -0700 From: Ian Lepore <ian@FreeBSD.org> To: Dag-Erling =?ISO-8859-1?Q?Sm=F8rgrav?= <des@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r274103 - head/sys/dev/random Message-ID: <1415144289.1200.125.camel@revolution.hippie.lan> In-Reply-To: <201411042302.sA4N2K4X063860@svn.freebsd.org> References: <201411042302.sA4N2K4X063860@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 2014-11-04 at 23:02 +0000, Dag-Erling Sm=F8rgrav wrote: > Author: des > Date: Tue Nov 4 23:02:19 2014 > New Revision: 274103 > URL: https://svnweb.freebsd.org/changeset/base/274103 >=20 > Log: > When reseeding the DPRNG, we're supposed to hash the current key and > some accumulated entropy twice and use that as the new key. Due to a > typo, we were using the output of the first hash round instead of the > second. Correct this, but eliminate temp[] since we can reuse hash[]. > Also add comments explaining what is going on and why. > =20 > Noticed by: Sami Farin <sami.farin@gmail.com> > Reviewed by: markm@ > Approved by: so (des) >=20 > Modified: > head/sys/dev/random/fortuna.c >=20 > Modified: head/sys/dev/random/fortuna.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/dev/random/fortuna.c Tue Nov 4 23:02:16 2014 (r274102) > +++ head/sys/dev/random/fortuna.c Tue Nov 4 23:02:19 2014 (r274103) > @@ -25,6 +25,17 @@ > * > */ > =20 > +/* This implementation of Fortuna is based on the descriptions found i= n > + * ISBN 0-471-22357-3 "Practical Cryptography" by Ferguson and Schneie= r > + * ("K&S"). I'm guessing s/b F&S. -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1415144289.1200.125.camel>