From owner-svn-src-head@freebsd.org  Fri Dec  8 18:57:15 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id B40EEE8B5C6;
 Fri,  8 Dec 2017 18:57:15 +0000 (UTC)
 (envelope-from rysto32@gmail.com)
Received: from mail-qt0-x22d.google.com (mail-qt0-x22d.google.com
 [IPv6:2607:f8b0:400d:c0d::22d])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 6F4117EDE3;
 Fri,  8 Dec 2017 18:57:15 +0000 (UTC)
 (envelope-from rysto32@gmail.com)
Received: by mail-qt0-x22d.google.com with SMTP id f2so28133949qtj.4;
 Fri, 08 Dec 2017 10:57:15 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :cc; bh=Q4XBSWr5r9/0IrhJSVIgFrjcPqXFUDGhexxVUhf/Kbc=;
 b=tJvD4J7AhBRKHmqCXuWoCXmMwViI6PVT9V0AGNcD4oLa29+0c6BGSIQSzke1ub2AaU
 flfa1CaA2UGAcMAAwyKm9JaMpE2wHnDCGU0ZfSTtFIjDLOwfnsJ3vPxyHuVlHqQYB/jj
 NikBpx+3LPH/iuDdmR51k/ybpsfHJkQCWSJCQLYUxnuTw7ZMXYUwH556lNPW/llWkcWn
 4WH7yrLOyunKTxcl0D5L2GnRK3yXcEYc95tpEZkT7V3TiYKWaANdpqjrnAuHjv71dxTA
 QDdNbflUGpL5Oj6PdHgA3ADXHVrOXc1F0sP95Jeh7U1KyGS3lUezsoaoU+CF3x94XFcr
 TLGg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc;
 bh=Q4XBSWr5r9/0IrhJSVIgFrjcPqXFUDGhexxVUhf/Kbc=;
 b=t5mqup+UBk5mMLQiT55twIPMUZvPMIi2Lh6RojLh07ZhIK9Sm2vgOTQ5hZ849PUz16
 iU5HMSG5UskX9YXDuXuXmmNSPyiVnzi6uVvXi4HeNErnGqBi6k8RZC+x4ktWzhXwIZq6
 9RT0CjPITiEbfDcw737QNtWU7Eu2/R7hEnB8e7amf9xdMVH+RxqK8u27Oh7brIWOiQJK
 J/t2IjbYdSHana3DvQaSlSAXiyCq3AbjMw2G1Y7GO0q0anWb8rtDlWC9CsY6uPbUL5Lh
 5MNx1pmlMK0XJXFtOl/Is5rJZdyk7vQ+/cBGM2g/MznPi9dM22pjLPxz1VwTBfLme9zo
 Vymg==
X-Gm-Message-State: AKGB3mKqLhxwTqRt7R5QWJDb/oTDXPqHeW3doOU68jPyhRS5UKDv7JxB
 4WnQAfLne0YeAlAzjNAKoTmi7p4+QaknbNALTRg=
X-Google-Smtp-Source: AGs4zMactPnUuVs8e26Hu5YqI9XuybwuRZ5hubAp2LF5/0b24hveItHA8Mo7Z1jQEeN2ynABEDq/BFuhAEo2iU+Jr2k=
X-Received: by 10.200.50.39 with SMTP id x36mr18752306qta.255.1512759434277;
 Fri, 08 Dec 2017 10:57:14 -0800 (PST)
MIME-Version: 1.0
Received: by 10.237.39.211 with HTTP; Fri, 8 Dec 2017 10:57:13 -0800 (PST)
In-Reply-To: <201712081843.vB8IhVdA064251@repo.freebsd.org>
References: <201712081843.vB8IhVdA064251@repo.freebsd.org>
From: Ryan Stone <rysto32@gmail.com>
Date: Fri, 8 Dec 2017 13:57:13 -0500
Message-ID: <CAFMmRNz1HFyxxoj4Mapdoa9puVjm21hGjOiKGB-0V3V2WpWOsw@mail.gmail.com>
Subject: Re: svn commit: r326702 - head/sys/net
To: Stephen Hurd <shurd@freebsd.org>
Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, 
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, 
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Dec 2017 18:57:15 -0000

On Fri, Dec 8, 2017 at 1:43 PM, Stephen Hurd <shurd@freebsd.org> wrote:
> Author: shurd
> Date: Fri Dec  8 18:43:31 2017
> New Revision: 326702
> URL: https://svnweb.freebsd.org/changeset/base/326702
> +       if (!M_WRITABLE(*m_head)) {
> +               new_head = m_dup(*m_head, M_NOWAIT);
> +               if (new_head == NULL) {
> +                       device_printf(dev, "cannot pad short frame, m_dup() failed");
> +                       return ENOMEM;


Don't we leak *m_head here?  As far as I can tell the caller doesn't
deal with it.