From owner-freebsd-net@FreeBSD.ORG  Wed Aug 22 13:26:41 2012
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 786EB1065672
	for <freebsd-net@freebsd.org>; Wed, 22 Aug 2012 13:26:41 +0000 (UTC)
	(envelope-from imp@bsdimp.com)
Received: from mail-pz0-f54.google.com (mail-pz0-f54.google.com
	[209.85.210.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 414EE8FC1D
	for <freebsd-net@freebsd.org>; Wed, 22 Aug 2012 13:26:41 +0000 (UTC)
Received: by dadr6 with SMTP id r6so785847dad.13
	for <freebsd-net@freebsd.org>; Wed, 22 Aug 2012 06:26:40 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=google.com; s=20120113;
	h=sender:subject:mime-version:content-type:from:in-reply-to:date:cc
	:content-transfer-encoding:message-id:references:to:x-mailer
	:x-gm-message-state;
	bh=cNzWHgU9ZibzOlCTJUGq2Bl4M+lRChyXB/vpy0ofcTg=;
	b=erqSESqYQbVHEVBEsg54VYsVtxSMf56wO8A3yq/Q7XhDZLZXHyA8VWSlLWxvDQ3ZV+
	zirfMPTz03wKX0DJ/BsH3v1kGUiB0Q9EJLoLb45g1N5RRl5F3hk9kTwa3QyRADqaw333
	YGjpKwJNSh8jncGXc5in6ZJnjPFGxDOQMdOxoJ+uVZffmO77FPz4gCIyPZ+OkFn4q/og
	++2w9CVUIjVIJmdoVqycCXsqUUrlBF5fRNL/J8HMBsLv9C9bLL0vePNViGjbcNFSG7gz
	bkaaJVVVcy1NzMJZyKhZ7dpVWp2q43aUwJNj4ryL7jnmSkX8ix7/qTmLWYDlNRgAhwzS
	iZ+g==
Received: by 10.66.86.166 with SMTP id q6mr45967443paz.83.1345642000454;
	Wed, 22 Aug 2012 06:26:40 -0700 (PDT)
Received: from [10.0.0.63] (50-78-194-198-static.hfc.comcastbusiness.net.
	[50.78.194.198])
	by mx.google.com with ESMTPS id hx9sm3710761pbc.68.2012.08.22.06.26.36
	(version=TLSv1/SSLv3 cipher=OTHER);
	Wed, 22 Aug 2012 06:26:37 -0700 (PDT)
Sender: Warner Losh <wlosh@bsdimp.com>
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
From: Warner Losh <imp@bsdimp.com>
In-Reply-To: <201208220802.14588.jhb@freebsd.org>
Date: Wed, 22 Aug 2012 07:26:34 -0600
Content-Transfer-Encoding: quoted-printable
Message-Id: <2DB48390-4FB8-49ED-A176-CF593ED57502@bsdimp.com>
References: <50324DB4.6080905@cabletv.dp.ua>
	<420BA06C-C776-47DB-B3BB-F1414C115F99@bsdimp.com>
	<CAJ-VmokQLD6YgyrsOyez=3cLm4Q8jZOnJ9vo4Wq3sjRu+G-E7A@mail.gmail.com>
	<201208220802.14588.jhb@freebsd.org>
To: John Baldwin <jhb@freebsd.org>
X-Mailer: Apple Mail (2.1084)
X-Gm-Message-State: ALoCoQmSYwZ91Cu9zWtGQDUXrrUqXPVJAH7tHYDmZ0UmPmT+QL0EA3D0vVX4Qa9Mmszgp6fdeUAK
Cc: freebsd-hackers@freebsd.org, Adrian Chadd <adrian@freebsd.org>,
	freebsd-net@freebsd.org, Mitya <mitya@cabletv.dp.ua>,
	Wojciech Puchar <wojtek@wojtek.tensor.gdynia.pl>
Subject: Re: Replace bcopy() to update ether_addr
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Aug 2012 13:26:41 -0000


On Aug 22, 2012, at 6:02 AM, John Baldwin wrote:

> On Tuesday, August 21, 2012 12:34:42 pm Adrian Chadd wrote:
>> Hi,
>>=20
>> What about just creating an ETHER_ADDR_COPY(dst, src) and putting =
that
>> in a relevant include file, then hide the ugliness there?
>>=20
>> The same benefits will likely appear when copying wifi MAC addresses
>> to/from headers.
>>=20
>> Thanks, I'm glad someone noticed this.
>=20
> I doubt we even _need_ the ugliness.  We should just use *dst =3D *src
> unless there is a compelling reason not to.

Agreed.  We should do that, and then check the generated code to be sure =
there isn't a compelling reason there :)

Warner