Date: Tue, 26 Feb 2019 19:57:20 +1100 From: Kubilay Kocak <koobs@FreeBSD.org> To: dimpase+freebsd@gmail.com, freebsd-ports@freebsd.org Subject: Re: [PATCH] lang/python27 -- Fix namespace collision Message-ID: <454163bf-1d26-dc82-855e-047fff585e6d@FreeBSD.org> In-Reply-To: <20190225133558.GA8874@hilbert> References: <20190225133558.GA8874@hilbert>
next in thread | previous in thread | raw e-mail | index | archive | help
On 26/02/2019 12:35 am, dimpase+freebsd@gmail.com wrote:
> On 6/20/17 Kubilay Kosak wrote:
>> On 6/19/17 4:31 AM, Steve Kargl wrote:
>> On Sun, Jun 18, 2017 at 11:29:05AM -0700, Steve Kargl wrote:
>>> Both IEEE-754 2008 and ISO/IEC TS 18661-4 define the half-cycle
>>> trignometric functions cospi, sinpi, and tanpi. When libm (aka
>>> math.h) grows support for sinpi(x), lang/python27 has a namespace
>>> collision. The attached patch fixes the problem.
>>>
>> Is this issue relevant only for particular (and/or future) FreeBSD
>> versions ('where libm grows supports for x, y') or independent of base
>> entirely?
>
>> Also, could you open an upstream issue regarding this please, as a
>> long-term target for all local (Python port) patches is that they are
>> included upstream.
>
> I've created a Python PR to fix this:
>
> https://github.com/python/cpython/pull/12027
>
> Dima
>
>> This also ensures we can document all patches with their relevant
>> upstream issue/commit references for our future selves and others.
>
>> ./koobs
> _______________________________________________
> freebsd-ports@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-ports
> To unsubscribe, send any mail to "freebsd-ports-unsubscribe@freebsd.org"
>
Thank you Dima! :)
I've added the upstream PR to #232792 [1] and will track upstream progress.
[1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232792
./koobs
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?454163bf-1d26-dc82-855e-047fff585e6d>