From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Jun 2 22:00:22 2011 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 856E21065688 for ; Thu, 2 Jun 2011 22:00:22 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 8BECB8FC16 for ; Thu, 2 Jun 2011 22:00:21 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p52M0L0v012770 for ; Thu, 2 Jun 2011 22:00:21 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p52M0L7v012769; Thu, 2 Jun 2011 22:00:21 GMT (envelope-from gnats) Resent-Date: Thu, 2 Jun 2011 22:00:21 GMT Resent-Message-Id: <201106022200.p52M0L7v012769@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Chris Rees Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3A7FD106566C for ; Thu, 2 Jun 2011 21:58:22 +0000 (UTC) (envelope-from utisoft@hotmail.com) Received: from blu0-omc1-s7.blu0.hotmail.com (blu0-omc1-s7.blu0.hotmail.com [65.55.116.18]) by mx1.freebsd.org (Postfix) with ESMTP id EE94D8FC08 for ; Thu, 2 Jun 2011 21:58:21 +0000 (UTC) Received: from BLU0-SMTP139 ([65.55.116.9]) by blu0-omc1-s7.blu0.hotmail.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 2 Jun 2011 14:58:21 -0700 Received: from zeus.bayofrum.net ([90.221.7.100]) by BLU0-SMTP139.phx.gbl over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Thu, 2 Jun 2011 14:58:19 -0700 Received: from zeus.bayofrum.net (crees@localhost [127.0.0.1]) by zeus.bayofrum.net (8.14.4/8.14.4) with ESMTP id p52LvcCw011328 (version=TLSv1/SSLv3 cipher=DHE-DSS-AES256-SHA bits=256 verify=NO) for ; Thu, 2 Jun 2011 22:57:39 +0100 (BST) (envelope-from chris@zeus.bayofrum.net) Received: (from crees@localhost) by zeus.bayofrum.net (8.14.4/8.14.4/Submit) id p52Lvcxr011327; Thu, 2 Jun 2011 22:57:38 +0100 (BST) (envelope-from chris) Message-Id: Date: Thu, 2 Jun 2011 22:57:38 +0100 From: Chris Rees Sender: To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/157546: [PATCH] Add feature to bsd.port.mk: Warn on deinstall about groups created by port X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Chris Rees List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Jun 2011 22:00:22 -0000 >Number: 157546 >Category: ports >Synopsis: [PATCH] Add feature to bsd.port.mk: Warn on deinstall about groups created by port >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Thu Jun 02 22:00:21 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Chris Rees >Release: FreeBSD 8.2-RELEASE-p1 i386 >Organization: >Environment: System: FreeBSD zeus.bayofrum.net 8.2-RELEASE-p1 FreeBSD 8.2-RELEASE-p1 #0: Sat Apr 30 15:09:06 BST 2011 root@zeus.bayofrum.net:/usr/obj/usr/src/sys/ZEUS i386 >Description: While working on fixing ports to use USERS people in IRC were wishing that ports warned on deinstall about groups created, just as it does for users. The attached patch should have that effect. >How-To-Repeat: >Fix: Warn users on deinstall about GROUPS created by port, as is already done for USERS. Submitted by: Chris Rees (utisoft@gmail.com) --- bsd-port-mk-groups-remove-warn.patch begins here --- --- bsd.port.mk.orig 2011-06-02 22:40:47.282578549 +0100 +++ bsd.port.mk 2011-06-02 22:46:58.023260860 +0100 @@ -1280,6 +1280,10 @@ # alpha numeric sort order USERS_BLACKLIST= _dhcp _pflogd bin bind daemon games kmem mailnull man news nobody operator pop proxy root smmsp sshd toor tty uucp www +# predefined accounts from src/etc/group +# alpha numeric sort order +GROUPS_BLACKLIST= _dhcp _pflogd audit authpf bin bind daemon dialer ftp games guest kmem mail mailnull man network news nobody nogroup operator proxy smmsp sshd staff sys tty uucp wheel www + LDCONFIG_DIR= libdata/ldconfig LDCONFIG32_DIR= libdata/ldconfig32 @@ -4267,6 +4271,14 @@ fi .endfor .endif +.if defined(GROUPS) +.for _group in ${GROUPS} + @if [ ! ${GROUPS_BLACKLIST:M${_group}} ] ; then \ + ${ECHO_CMD} "@unexec if ${PW} groupshow ${_group} >/dev/null 2>&1; then \ + echo \"==> You should manually remove the \\\"${_group}\\\" group. \"; fi" >> ${TMPPLIST}; \ + fi +.endfor +.endif # defined(GROUPS) .endif .else @${DO_NADA} --- bsd-port-mk-groups-remove-warn.patch ends here --- -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean. >Release-Note: >Audit-Trail: >Unformatted: