From nobody Thu Dec 7 14:40:21 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SmH4P6s0tz535Xv; Thu, 7 Dec 2023 14:40:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SmH4P6Ng7z4GL4; Thu, 7 Dec 2023 14:40:21 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701960021; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WWkwOsGndDiSJS6yXH99Nwl3wuPJbkr3v4Q51D5/yK8=; b=H3dEEnkSE+DDbtrbJaXFv8zgWfc4oSd9HphjCOt1AxBVz+jOrXIMeSapOvi673g8VCq87H f4o0aaSlX6BNOzKx7Q3VuJafgnlMMaE2DZmL8D6n0dFoV+eD6tQsCQOwY2akPzpr2anAf5 ueoMqbv1mGB70+nUoNcLoXCsX7g1qTwfP2QuB9h7BlbUJVfOJ14dvURvhCEdUwxnumqf15 oLR9MwwOUa0toUpfI9KXPKBlKHeqA8Gtx1kMk+g+Gv1txNGmAHmymdN8gr5X99XvN5KnRR VTiZvOo1wzxHsnapZ0V+YsYH1gsu+/yfCEjK6Y1u3Fc8O5M+lhXXVCYUHl32hA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1701960021; a=rsa-sha256; cv=none; b=WnDd31+uG8wUjCWjWkpC8oOz8/XUuNsGPSEHq5UtAWlxgtsfspHZPBe6hZlBEZAb82y9Kb jZSjXzg/MHr/C7UDiQx5Yj3e+OPhvnqWULtUciQrU5waS3N1RRHShSkXbCCd25AxfWuWGQ W66dN5edKpUhnQ+LxCY7i3TkCzZtjfSlY1NaCMV/xgzuX6saEiqHTqca5xjl6Me5bcYAm+ SEKwxVtPefCDQEvSSGMgNYaJ4XILOm6WjtXFe0GX3Z8WCcOaKfyCJSsdmSc8KE8twa7Db6 n4a+oPWVDmugMoT4Sn1ne1T2Whqct+NvrsNBFBvpHPpYIHCcCjn6e2ob/QuybQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701960021; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WWkwOsGndDiSJS6yXH99Nwl3wuPJbkr3v4Q51D5/yK8=; b=go3eyRld22F56kIeBlrwn3n4awXkC8xgxWIatbTo0gqT4/Q2+rcdDmecDFVN91+Hc30w1O kRnUMr60M8FN5xsl92pg9UUr7KV006FDeCE3V7vmiBPEbBHuT75Wahkkic4RIpEIE27kYG 7Y8ma3FepuLuknDQ2fp4AxMcNQl6R07jlmaURvTBh/FtW0yJiCZlvvi5ITMWIAPz+fzRKb WhyBDsJdu026v07Arsm9tocRsqoxaqr19AotlRU9wI6AbNWVnXBaOqXcXGPd3LkV6yi1wk 40TNP5gFRCoqvBZSsUQi/j6wT9Gt8vnlQgGYwoB7Zrgy/iYDHApgW5E/68faqg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SmH4P5LWSzgd5; Thu, 7 Dec 2023 14:40:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 3B7EeLNi059293; Thu, 7 Dec 2023 14:40:21 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 3B7EeLfG059290; Thu, 7 Dec 2023 14:40:21 GMT (envelope-from git) Date: Thu, 7 Dec 2023 14:40:21 GMT Message-Id: <202312071440.3B7EeLfG059290@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Richard Scheffenegger Subject: git: 9276ad23b872 - main - tcp: shift PRR sending cadence slightly left List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rscheff X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 9276ad23b872eddc42e05304acb10bf5421b043c Auto-Submitted: auto-generated The branch main has been updated by rscheff: URL: https://cgit.FreeBSD.org/src/commit/?id=9276ad23b872eddc42e05304acb10bf5421b043c commit 9276ad23b872eddc42e05304acb10bf5421b043c Author: Richard Scheffenegger AuthorDate: 2023-12-07 14:13:05 +0000 Commit: Richard Scheffenegger CommitDate: 2023-12-07 14:37:45 +0000 tcp: shift PRR sending cadence slightly left Don't let PRR pass up on the opportunity of clocking out packets on arrival of ACKs - by pulling sends forward by about half a packet. Prevents unexpectedly long runs of incoming ACKs without eliciting a packet transmission. MFC after: 1 week Reviewed By: #transport, tuexen Sponsored by: NetApp, Inc. Differential Revision: https://reviews.freebsd.org/D42918 --- sys/netinet/tcp_input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/netinet/tcp_input.c b/sys/netinet/tcp_input.c index b26ae92a767e..05f9a4a9726a 100644 --- a/sys/netinet/tcp_input.c +++ b/sys/netinet/tcp_input.c @@ -3970,7 +3970,7 @@ tcp_do_prr_ack(struct tcpcb *tp, struct tcphdr *th, struct tcpopt *to, sackstatu imax(1, tp->snd_nxt - tp->snd_una); snd_cnt = howmany((long)tp->sackhint.prr_delivered * tp->snd_ssthresh, tp->sackhint.recover_fs) - - tp->sackhint.prr_out; + tp->sackhint.prr_out + maxseg - 1; } else { /* * PRR 6937bis heuristic: