From owner-svn-src-all@FreeBSD.ORG Sat Feb 25 12:06:41 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 350C01065686; Sat, 25 Feb 2012 12:06:41 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 244C78FC13; Sat, 25 Feb 2012 12:06:41 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q1PC6fSl016825; Sat, 25 Feb 2012 12:06:41 GMT (envelope-from maxim@svn.freebsd.org) Received: (from maxim@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id q1PC6eaF016823; Sat, 25 Feb 2012 12:06:40 GMT (envelope-from maxim@svn.freebsd.org) Message-Id: <201202251206.q1PC6eaF016823@svn.freebsd.org> From: Maxim Konovalov Date: Sat, 25 Feb 2012 12:06:40 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r232156 - head/sys/kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Feb 2012 12:06:41 -0000 Author: maxim Date: Sat Feb 25 12:06:40 2012 New Revision: 232156 URL: http://svn.freebsd.org/changeset/base/232156 Log: o Reduce chances for integer overflow. o More verbose sysctl description added. MFC after: 2 weeks Sponsored by: Nginx, Inc. Modified: head/sys/kern/vfs_cache.c Modified: head/sys/kern/vfs_cache.c ============================================================================== --- head/sys/kern/vfs_cache.c Sat Feb 25 11:07:32 2012 (r232155) +++ head/sys/kern/vfs_cache.c Sat Feb 25 12:06:40 2012 (r232156) @@ -369,7 +369,7 @@ sysctl_debug_hashstat_nchash(SYSCTL_HAND maxlength = count; } n_nchash = nchash + 1; - pct = (used * 100 * 100) / n_nchash; + pct = (used * 100) / (n_nchash / 100); error = SYSCTL_OUT(req, &n_nchash, sizeof(n_nchash)); if (error) return (error); @@ -386,7 +386,7 @@ sysctl_debug_hashstat_nchash(SYSCTL_HAND } SYSCTL_PROC(_debug_hashstat, OID_AUTO, nchash, CTLTYPE_INT|CTLFLAG_RD| CTLFLAG_MPSAFE, 0, 0, sysctl_debug_hashstat_nchash, "I", - "nchash chain lengths"); + "nchash statistics (number of total/used buckets, maximum chain length, usage percentage)"); #endif /*