From owner-cvs-src@FreeBSD.ORG Mon May 5 18:59:12 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 74579106564A; Mon, 5 May 2008 18:59:12 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 44DFD8FC1F; Mon, 5 May 2008 18:59:12 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unknown [208.65.91.234]) by elvis.mu.org (Postfix) with ESMTP id D39C41A4D80; Mon, 5 May 2008 11:59:11 -0700 (PDT) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m45Iwx4Z069611; Mon, 5 May 2008 14:59:00 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Alfred Perlstein Date: Mon, 5 May 2008 14:59:28 -0400 User-Agent: KMail/1.9.7 References: <200805051603.m45G3rrN089219@repoman.freebsd.org> <20080505184003.GL32532@elvis.mu.org> In-Reply-To: <20080505184003.GL32532@elvis.mu.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200805051459.29200.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Mon, 05 May 2008 14:59:00 -0400 (EDT) X-Virus-Scanned: ClamAV 0.91.2/7035/Mon May 5 13:47:07 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/include stdio.h src/lib/libc/stdio clrerr.c feof.c ferror.c fileno.c getc.c getchar.c local.h putc.c putchar.c xprintf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 May 2008 18:59:12 -0000 On Monday 05 May 2008 02:40:03 pm Alfred Perlstein wrote: > I'm _not_ objecting, just interested in why. > > Any references to discussions on this? Are we now safe for > future compat or something? Having FILE be opaque broke just about every 'configure' script on the planet. :( > * John Baldwin [080505 09:04] wrote: > > jhb 2008-05-05 16:03:52 UTC > > > > FreeBSD src repository > > > > Modified files: > > include stdio.h > > lib/libc/stdio clrerr.c feof.c ferror.c fileno.c getc.c > > getchar.c local.h putc.c putchar.c > > xprintf.c > > Log: > > Expose FILE's internals to the world again in all their glory. Restore > > all the previous inline optimizations as well. FILE is back to using > > __mbstate_t, struct pthread *, and struct pthread_mutex *. > > > > Revision Changes Path > > 1.70 +172 -4 src/include/stdio.h > > 1.12 +2 -2 src/lib/libc/stdio/clrerr.c > > 1.12 +2 -2 src/lib/libc/stdio/feof.c > > 1.12 +3 -1 src/lib/libc/stdio/ferror.c > > 1.13 +2 -2 src/lib/libc/stdio/fileno.c > > 1.16 +3 -0 src/lib/libc/stdio/getc.c > > 1.15 +3 -0 src/lib/libc/stdio/getchar.c > > 1.33 +2 -132 src/lib/libc/stdio/local.h > > 1.16 +3 -0 src/lib/libc/stdio/putc.c > > 1.16 +3 -0 src/lib/libc/stdio/putchar.c > > 1.8 +0 -1 src/lib/libc/stdio/xprintf.c > > -- > - Alfred Perlstein > -- John Baldwin