From owner-svn-src-all@freebsd.org Sat Oct 17 16:39:51 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8738643C659 for ; Sat, 17 Oct 2020 16:39:51 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x842.google.com (mail-qt1-x842.google.com [IPv6:2607:f8b0:4864:20::842]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CD7zB1xqTz4Nlp for ; Sat, 17 Oct 2020 16:39:49 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x842.google.com with SMTP id r8so3529508qtp.13 for ; Sat, 17 Oct 2020 09:39:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3HVQC4jzB93RbLJK6XZQBe9OwE7El8jcY3UR1rJAxtQ=; b=LtjR1bP0vUHHKB2477ox0UpfBA9rsQs1n0XE+oXQBCI/N56WDeXklBUiOzLL4jtbpY MYTIbtRc/l1ybOSKQ2r08PeuGyozYFJgxsK/JgUEXI8RyfWP6EZd5UefJ8H3t4yzD2yS m1M1t7t6r7TarTNEFqTSww6wBnoI5aBnWXSu5R2FjZ+qBJ8ipNMLDbkVReWNZjrRpy3b l+OhMN8azKLQUeEl8K5wmBpnw9EKOmFx1tqmyHgvnB8H5zfAFMpKaFN0iqaormy17/kJ z7GamrhOEz9C6DpHWLoKWi41xgWuU5h373w0b3JTMuRK4HqKtV+usLjqRBjS4QRDcZ96 enng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3HVQC4jzB93RbLJK6XZQBe9OwE7El8jcY3UR1rJAxtQ=; b=q1jcpjj3SGMg754s6bayojAM/2poQG41c0vlcSQc4VCaRq79R/vICCY5HCu0eSsVvb mxsK0HoZVEb3J2jD7cyVHs4rTL6cxLyv89gyQyfshP+CLLnv1SPHlGeuAHbdtOG8cAL+ YWJoPHinYQFwVxUZQiyHxjfbawvq/V6A43NxgMkU0s3d5IIHcfuxmsKgh/MqjgErLyVW zWFpFuyk1eNmXWN8RtTHKU67v/zdQDZ7lv8UrEXN8QGORjpLabg0KYsR1LLqFmMhX9eS xZ2dGC54LBZ7Kbzn/7ch5db//RUQvZnJ60x1hmlMrXQkw8k6LN7M4oVOcnxkGVbhaj77 Ulnw== X-Gm-Message-State: AOAM532krVvz1B8OGZqoOM8baQB4VGJJ+6PmBwDhYAnv2d5A0zEaEoe3 YMbrroEpMvERFS8UgRHwJBdYL9QpQsZ7YvhJtHtITolu0KQ= X-Google-Smtp-Source: ABdhPJzk2gEqL7nRoIRgadRKhAD0aaxhu2YCoNe8suIjX7wVPhbE1OYdJkvTcgpm0gQN+/xVL9BychtNZZ/klYn7dfg= X-Received: by 2002:ac8:7247:: with SMTP id l7mr8266869qtp.244.1602952789089; Sat, 17 Oct 2020 09:39:49 -0700 (PDT) MIME-Version: 1.0 References: <202010021826.092IQfdj023808@repo.freebsd.org> <44421602932538@mail.yandex.ru> <43251602934532@mail.yandex.ru> <59021602950992@mail.yandex.ru> In-Reply-To: <59021602950992@mail.yandex.ru> From: Warner Losh Date: Sat, 17 Oct 2020 10:39:37 -0600 Message-ID: Subject: Re: svn commit: r366372 - in head/sys: compat/linuxkpi/common/include/linux compat/linuxkpi/common/src conf To: "Alexander V. Chernikov" Cc: Hans Petter Selasky , Emmanuel Vadot , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" X-Rspamd-Queue-Id: 4CD7zB1xqTz4Nlp X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=LtjR1bP0; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::842) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-1.31 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-0.89)[-0.890]; NEURAL_HAM_LONG(-0.96)[-0.965]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; RCPT_COUNT_FIVE(0.00)[6]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_SPAM_SHORT(0.44)[0.443]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; MIME_BASE64_TEXT(0.10)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::842:from]; R_SPF_NA(0.00)[no SPF record]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; MAILMAN_DEST(0.00)[svn-src-all]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Oct 2020 16:39:51 -0000 On Sat, Oct 17, 2020, 10:11 AM Alexander V. Chernikov wrote: > 17.10.2020, 14:07, "Hans Petter Selasky" : > > On 2020-10-17 14:34, Alexander V. Chernikov wrote: > > 17.10.2020, 12:32, "Hans Petter Selasky" : > > On 2020-10-17 13:27, Alexander V. Chernikov wrote: > > 02.10.2020, 19:26, "Emmanuel Vadot" >>: > > Author: manu > Date: Fri Oct 2 18:26:41 2020 > New Revision: 366372 > URL: https://svnweb.freebsd.org/changeset/base/366372 > > Log: > linuxkpi: Add backlight support > > Add backlight function to linuxkpi. > Graphics drivers expose the backlight of the panel > directly so > allow them > to use the backlight subsystem so > user can use backlight(8) to configure them. > > Reviewed by: hselasky > Relnotes: yes > Differential Revision: The FreeBSD Foundation > > Added: > > head/sys/compat/linuxkpi/common/include/linux/backlight.h > (contents, > props changed) > Modified: > head/sys/compat/linuxkpi/common/include/linux/device.h > head/sys/compat/linuxkpi/common/src/linux_kmod.c > head/sys/compat/linuxkpi/common/src/linux_pci.c > head/sys/conf/kmod.mk > > It breaks the build for me with > > /usr/home/melifaro/free/head/sys/compat/linuxkpi/common/src/linux_pci.c:70:10: > fatal error: 'backlight_if.h' file not found > > > How do you build? Doesn't break over here. > > GENERIC + COMPAT_LINUXKPI. > > > > Try adding: > > options backlight > > To the kernel config. > > Yep, thank you! > Maybe it's worth considering adding static assert with the message > describing this dependency? > Yes. It likely is worth doing something to highlight this issue. Warner --HPS > > >