From owner-freebsd-dtrace@FreeBSD.ORG Wed Aug 7 07:47:45 2013 Return-Path: Delivered-To: freebsd-dtrace@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id A264E5B0; Wed, 7 Aug 2013 07:47:45 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id C2D8C208A; Wed, 7 Aug 2013 07:47:44 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id KAA20646; Wed, 07 Aug 2013 10:47:42 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1V6yT8-000O3v-Fh; Wed, 07 Aug 2013 10:47:42 +0300 Message-ID: <5201FB7A.4050106@FreeBSD.org> Date: Wed, 07 Aug 2013 10:47:06 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130708 Thunderbird/17.0.7 MIME-Version: 1.0 To: Mark Johnston Subject: Re: [RFC] reworking FreeBSD's SDT implementation References: <20130703041023.GA82673@raichu> <20130711024500.GA67976@raichu> <20130711210215.GB7506@gmail.com> <20130713234200.GA40803@raichu> <20130714075634.GC2832@gmail.com> <20130722022811.GA14288@raichu> <51F14150.7000509@FreeBSD.org> <20130727022656.GB67227@raichu> <51F372C8.1000107@FreeBSD.org> <20130804015122.GA3259@raichu> In-Reply-To: <20130804015122.GA3259@raichu> X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-dtrace@FreeBSD.org X-BeenThere: freebsd-dtrace@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "A discussion list for developers working on DTrace in FreeBSD." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Aug 2013 07:47:45 -0000 on 04/08/2013 04:51 Mark Johnston said the following: > I implemented the module load/unload events a couple of days ago using > EVENTHANDLER(9), and it looks like everything works properly. I copied > the trick used for watchdog_list and just added an error pointer > argument to the unload handlers. The revised patch is here: > > http://people.freebsd.org/~markj/patches/sdt-module-info/20130803-sdt-module-info.diff This looks good to me. Thank you very much! -- Andriy Gapon