From owner-freebsd-net@FreeBSD.ORG  Thu Jul 14 07:56:32 2005
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
X-Original-To: freebsd-net@freebsd.org
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0CEA216A41F
	for <freebsd-net@freebsd.org>; Thu, 14 Jul 2005 07:56:32 +0000 (GMT)
	(envelope-from raglon@packetfront.com)
Received: from mail.packetfront.com (mail.packetfront.com [212.247.6.198])
	by mx1.FreeBSD.org (Postfix) with ESMTP id CFA5C43D53
	for <freebsd-net@freebsd.org>; Thu, 14 Jul 2005 07:56:30 +0000 (GMT)
	(envelope-from raglon@packetfront.com)
Received: from localhost (localhost [127.0.0.1])
	by mail.packetfront.com (Postfix) with ESMTP id 5C13FA3F4B;
	Thu, 14 Jul 2005 09:56:28 +0200 (CEST)
Received: from mail.packetfront.com ([127.0.0.1])
	by localhost (mail [127.0.0.1]) (amavisd-new, port 10024) with ESMTP
	id 09674-06; Thu, 14 Jul 2005 09:56:28 +0200 (CEST)
Received: from [192.168.1.159] (pf-raglon.int.packetfront.com [192.168.1.159])
	by mail.packetfront.com (Postfix) with ESMTP id 120C4A3F26;
	Thu, 14 Jul 2005 09:56:28 +0200 (CEST)
Message-ID: <42D61A8B.2090804@packetfront.com>
Date: Thu, 14 Jul 2005 09:55:55 +0200
From: Ragnar Lonn <raglon@packetfront.com>
User-Agent: Mozilla Thunderbird 0.8 (Windows/20040913)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: "Yuriy N. Shkandybin" <jura@networks.ru>
References: <02bc01c583c5$300fe070$6504010a@Jura>
In-Reply-To: <02bc01c583c5$300fe070$6504010a@Jura>
Content-Type: text/plain; charset=windows-1251; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at packetfront.com
Cc: freebsd-net@freebsd.org
Subject: Re: kern/83011: nge vlans broken
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Jul 2005 07:56:32 -0000

This is in 5.x, right?  I can't find this code in 4.11 at least.
Does that mean that ngeth VLAN support is broken in 5.x (without the patch)?

Regards,

  /Ragnar

Yuriy N. Shkandybin wrote:

> I've invistigated that m_head mbuf doesn't have M_VLANTAG when 
> performing VLAN_OUTPUT()
>
> next diff for /usr/src/sys/net/if_vlan_var.h make it work:
> --- 1.h Fri Jul  8 17:34:31 2005
> +++ if_vlan_var.h       Fri Jul  8 17:35:53 2005
> @@ -111,7 +111,7 @@
> } while (0)
>
> #define        VLAN_OUTPUT_TAG(_ifp, _m)                               \
> -       ((_m)->m_flags & M_VLANTAG ?                            \
> +       ((_ifp)->if_nvlans != 0 ?                               \
>                m_tag_locate((_m), MTAG_VLAN, MTAG_VLAN_TAG, NULL) : NULL)
> #define        VLAN_TAG_VALUE(_mt)     (*(u_int *)((_mt)+1))
> #endif /* _KERNEL */
>
>
> Actually this is partial backout ru@ commit
> http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/net/if_vlan_var.h.diff?r1=1.20&r2=1.21&f=h 
>
>
> Since it's not adressed to if_nge itself, so it's possible same 
> problems for another interfaces.
>
> Jura
>
>
> _______________________________________________
> freebsd-net@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-net
> To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"