From nobody Mon Jun 23 21:54:28 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bR21061Q9z5yr22; Mon, 23 Jun 2025 21:54:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bR2104Z65z3W57; Mon, 23 Jun 2025 21:54:28 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1750715668; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=oHixIfNmgA9LOz5VHDCNpN468m6cwREULlajE1ooCY8=; b=iPzoRpR9MnQqTnVsz27MU7l00atC8YXsdIsW71FzfNZtoeorjuIGwXXxWr12rfAGz1xg9+ Blktk50fY8kzh8s/ptkiN/txwAFhoHYY5S9coHYfvQpE6YEQsB41rB1+QjhU3MK1C2N0CW jCcIiL6MCuUE8MZA91z7gSlDSMgvUSPWJ0aOsYGbtvTz5Fjv9TMLD0ttbGg4fG4g9N6Jmm AdRH2Ma9Yi0ILknAc3dAsOxaKkry001NXhm/9H30JGvDkzbbzLWOe1JZfGbtzfAFBVIBne VyWLoMZv7YED+5ONHHsVX1fVLgw6LurJX26hwfI4eEBWea3CAcTLn2zch70kZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1750715668; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=oHixIfNmgA9LOz5VHDCNpN468m6cwREULlajE1ooCY8=; b=yNHmtPxKN4ykWMuR85ZmnDYAE4jsFjoFj5EaXA5WFQluUDjtH5gOJSwqkZBDOK5VrnFvdk /nBR7XkIikhP+TTHarsqE5bHbvQDimmsVDh7ijZmjkljvl8CxvNFqtBRvpusTvC4z6+eyG Nj+/blBPg++mX/mLqHRFWFk7bYIZNTBwZ8lqcXs1SUgvQ2OPQDEo/l3518h7rawvFUCzLk 3lucHZvwdDfTRIYopuGJ9K17ig4raFl2BWjt2DZhRH7ZLIYTaKALrjQBC+QhwFnYU/YMIM V0K6CG6Dc4noQBTSUfmSntS6z/o+vP9EWdwvRd5+Gv7aiUs+mczZYClxOdjveA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1750715668; a=rsa-sha256; cv=none; b=tlLCRVh9eQpPJ70tHA/hjMILMJ8xQgzlNdW5XI6c8w1hgisqV4rcof57RQ1Y/UJkYyCROF pAuw75ClWtuCSmUoXOpeY69kdtihvLbcBMpL8zhTL8ZLffp1siAuo9D6w5wx8acYqsxgXc O9D6ghud6R1LAHEVtHLPyFfpgXRTQsMiN+kz3+0oCdIGk3C9MAZmVFIXedSi/6Qgd+KLzs d5J2qP0yzV6g3C1Avzp4F71NZzIbmlQVKZgPs+ldKii59oPudC2sIewc4JfjKx7X0J2341 b0J7DiRiY60mob9BOvymbdfwMe5MAdoN++XFYRYvKtd2SpqtsWP3TcAJPP947A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bR21044HPz5B9; Mon, 23 Jun 2025 21:54:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 55NLsSXk071377; Mon, 23 Jun 2025 21:54:28 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 55NLsSIs071374; Mon, 23 Jun 2025 21:54:28 GMT (envelope-from git) Date: Mon, 23 Jun 2025 21:54:28 GMT Message-Id: <202506232154.55NLsSIs071374@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: =?utf-8?Q?Jean-S=C3=A9bastien?= =?utf-8?Q?P=C3=A9dron?= Subject: git: 81e6c0168d46 - main - lindebugfs.c: Fix possible NULL dereference List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dumbbell X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 81e6c0168d46b0f5d5d4c5d0405caca8da24c35e Auto-Submitted: auto-generated The branch main has been updated by dumbbell: URL: https://cgit.FreeBSD.org/src/commit/?id=81e6c0168d46b0f5d5d4c5d0405caca8da24c35e commit 81e6c0168d46b0f5d5d4c5d0405caca8da24c35e Author: Jean-Sébastien Pédron AuthorDate: 2025-06-18 20:32:13 +0000 Commit: Jean-Sébastien Pédron CommitDate: 2025-06-23 21:43:51 +0000 lindebugfs.c: Fix possible NULL dereference If `debugfs_destroy()` is called early as part of error handling during initialzation, `pn->pn_data` is unset. This led to a panic in that if because `dm` is NULL. Reviewed by: bz Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D50985 --- sys/compat/lindebugfs/lindebugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/compat/lindebugfs/lindebugfs.c b/sys/compat/lindebugfs/lindebugfs.c index 97f73e79fb6c..50f9377ffec3 100644 --- a/sys/compat/lindebugfs/lindebugfs.c +++ b/sys/compat/lindebugfs/lindebugfs.c @@ -104,7 +104,7 @@ debugfs_destroy(PFS_DESTROY_ARGS) struct dentry_meta *dm; dm = pn->pn_data; - if (dm->dm_type == DM_SYMLINK) + if (dm != NULL && dm->dm_type == DM_SYMLINK) free(dm->dm_data, M_DFSINT); free(dm, M_DFSINT);