From owner-svn-src-all@FreeBSD.ORG Fri Mar 12 00:18:38 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CFB611065769; Fri, 12 Mar 2010 00:18:38 +0000 (UTC) (envelope-from tomelite82@gmail.com) Received: from mail-qy0-f175.google.com (mail-qy0-f175.google.com [209.85.221.175]) by mx1.freebsd.org (Postfix) with ESMTP id 2A4778FC19; Fri, 12 Mar 2010 00:18:37 +0000 (UTC) Received: by qyk5 with SMTP id 5so669414qyk.13 for ; Thu, 11 Mar 2010 16:18:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type:content-transfer-encoding; bh=iyJauxMwoyCdmQcnxGe4Bxg/NeWqA1oGVftaxqRDx6E=; b=JZLls9VloaJEPI35b6iRcyLKVsZZQaJHfK8xNCSuU2FygF11nX6OEZFwQ/eLHPCm/7 c9rNkAPY6XcGEGhZb8arYsNzjq9IyDyytOVbpScUvczpZDhErHfvkP7o/EBJsfsnMXtO 0Uz9a+X6RTLe/+FPOuopkDBpzZVct5hkfuZPM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=L1A2vKIVpzepDiUNRmw10DMJHFAML96HQoeUZQ1dKDqb3jPSsdgvDYHuKbjL30cSAf v7csnzBWTmyyxY8st95o18m/AMkUm3Fv7Cw6htGtXAu4T56YfB4CEvuyxstuLuQlVcSF ZQ/Ee7mbbr6YAOoo1wmw8K3gxftkwbf0gdyt4= MIME-Version: 1.0 Sender: tomelite82@gmail.com Received: by 10.220.107.17 with SMTP id z17mr432676vco.75.1268353117106; Thu, 11 Mar 2010 16:18:37 -0800 (PST) In-Reply-To: References: <201003111756.o2BHukJu042449@svn.freebsd.org> <9ace436c1003111530s3bd0de9cq451671909fb6aa64@mail.gmail.com> <9ace436c1003111539t2af8439cn315c695d4b90e28d@mail.gmail.com> Date: Thu, 11 Mar 2010 16:18:37 -0800 X-Google-Sender-Auth: a6c4769d7ed44980 Message-ID: <9ace436c1003111618t28dba8d8x19aeff2acff0c489@mail.gmail.com> From: Qing Li To: Juli Mallett Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Robert Watson Subject: Re: svn commit: r205024 - head/sys/net X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Mar 2010 00:18:38 -0000 > > If you can think of a way to add some invariants (warn the first time > a driver receives a packet without having ever set the link state, > make sure the media status callback sets the valid flag in the > request, etc) that would probably be very helpful for people who are > writing network drivers. =A0If I hadn't been following the threads about > your changes, I would have had to spend much longer fixing the Octeon > port's Ethernet driver, wondering why suddenly it broke and > instrumenting the routing code. =A0A printf would go a long way. > You definitely have a very good point here. I was a bit surprised during debugging that the link state is not consistently initialized and by far not enforced across all of the drivers. Admittedly I checked the most commonly deployed devices and they are in good state. I certainly appreciate your patience on this one and will try to get it resolved quickly. -- Qing